[AWS logs forwarder] Support Python 3.12 #878
Conversation
ge0Aja
force-pushed
the
georgi/py-3-12
branch
2 times, most recently
from
3cf5100 to
a3e4a52
Compare
ge0Aja
changed the title
ge0Aja
force-pushed
the
georgi/py-3-12
branch
from
a3e4a52 to
1c4d0b9
Compare
ge0Aja
changed the title
![datadog-datadog-prod-us1[bot]](https://avatars.githubusercontent.com/u/365230?s=60&v=4){kind=small}
| if "x-datadog-trace-id" in event["headers"]: | ||
| event["headers"]["x-datadog-trace-id"] = "<redacted from snapshot>" |
There was a problem hiding this comment.
🔴 Code Quality Violation
too many nesting levels (...read more)
Avoid to nest too many loops together. Having too many loops make your code harder to understand.
Prefer to organize your code in functions and unit of code you can clearly understand.
Learn More
| if "traceparent" in event["headers"]: | ||
| event["headers"]["traceparent"] = "<redacted from snapshot>" |
There was a problem hiding this comment.
🔴 Code Quality Violation
too many nesting levels (...read more)
Avoid to nest too many loops together. Having too many loops make your code harder to understand.
Prefer to organize your code in functions and unit of code you can clearly understand.
Learn More
| if "tracestate" in event["headers"]: | ||
| event["headers"]["tracestate"] = "<redacted from snapshot>" |
There was a problem hiding this comment.
🔴 Code Quality Violation
too many nesting levels (...read more)
Avoid to nest too many loops together. Having too many loops make your code harder to understand.
Prefer to organize your code in functions and unit of code you can clearly understand.
Learn More
| if "x-datadog-tags" in event["headers"]: | ||
| event["headers"]["x-datadog-tags"] = "<redacted from snapshot>" |
There was a problem hiding this comment.
🔴 Code Quality Violation
too many nesting levels (...read more)
Avoid to nest too many loops together. Having too many loops make your code harder to understand.
Prefer to organize your code in functions and unit of code you can clearly understand.
Learn More
ge0Aja
force-pushed
the
georgi/py-3-12
branch
from
1c4d0b9 to
a2051ed
Compare
| wrapt==1.14.0 | ||
| xmltodict | ||
| zipp | ||
| ujson |
There was a problem hiding this comment.
🔴 Library Vulnerability
ujson
Incorrect handling of invalid surrogate pair characters (...read more)
Impact
What kind of vulnerability is it? Who is impacted?
Anyone parsing JSON from an untrusted source is vulnerable.
JSON strings that contain escaped surrogate characters not part of a proper surrogate pair were decoded incorrectly. Besides corrupting strings, this allowed for potential key confusion and value overwriting in dictionaries.
Examples:
# An unpaired high surrogate character is ignored.
>>> ujson.loads(r'"\uD800"')
''
>>> ujson.loads(r'"\uD800hello"')
'hello'
# An unpaired low surrogate character is preserved.
>>> ujson.loads(r'"\uDC00"')
'\udc00'
# A pair of surrogates with additional non surrogate characters pair up in spite of being invalid.
>>> ujson.loads(r'"\uD800foo bar\uDC00"')
'foo bar𐀀'Patches
Has the problem been patched? What versions should users upgrade to?
Users should upgrade to UltraJSON 5.4.0.
From version 5.4.0, UltraJSON decodes lone surrogates in the same way as the standard library's json module does, preserving them in the parsed output:
>>> ujson.loads(r'"\uD800"')
'\ud800'
>>> ujson.loads(r'"\uD800hello"')
'\ud800hello'
>>> ujson.loads(r'"\uDC00"')
'\udc00'
>>> ujson.loads(r'"\uD800foo bar\uDC00"')
'\ud800foo bar\udc00'Workarounds
Is there a way for users to fix or remediate the vulnerability without upgrading?
Short of switching to an entirely different JSON library, there are no safe alternatives to upgrading.
For more information
If you have any questions or comments about this advisory:
- Open an issue in UltraJSON
|
these new versions require 3.12 runtime it appears? |
3 participants
What does this PR do?
Motivation
Testing Guidelines
Additional Notes
Types of changes
Check all that apply