Skip to content

Conversation

ge0Aja
Copy link
Contributor

@ge0Aja ge0Aja commented Jan 6, 2025

What does this PR do?

Pulling off RDS source, service and host identification from the logs forwarder as we start migrating code towards Datadog backend.

This should be released with version >= 4.0.0

This should not have any effects on the outcome of the log processing as we'll still be setting these in Datadog's backend.

Motivation

We've started working on a project to gradually remove complex logic from Lambda forwarder towards Datadog backend. We're starting with migrating the logic around defining source, service and host info for a log.
RDS is the first source we're migrating.

Testing Guidelines

Additional Notes

Types of changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog
  • This PR passes the integration tests (ask a Datadog member to run the tests)
  • This PR passes the unit tests
  • This PR passes the installation tests (ask a Datadog member to run the tests)

@github-actions github-actions bot added the aws label Jan 6, 2025
@ge0Aja ge0Aja force-pushed the georgi/rds-source-identification branch from e29a7b0 to ac9b1b6 Compare January 6, 2025 16:19
@ge0Aja ge0Aja marked this pull request as ready for review January 15, 2025 16:45
@ge0Aja ge0Aja force-pushed the georgi/rds-source-identification branch from 836dd02 to 7c9d777 Compare January 16, 2025 09:04
@ge0Aja ge0Aja merged commit 7e55632 into master Jan 16, 2025
12 checks passed
@ge0Aja ge0Aja deleted the georgi/rds-source-identification branch January 16, 2025 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants