Skip to content

Conversation

ktmq
Copy link
Contributor

@ktmq ktmq commented Jan 31, 2025

What does this PR do?

Fixes some approval tests that weren't updated, and appease the linter

Motivation

Testing Guidelines

Additional Notes

Types of changes

  • Bug fix
  • New feature
  • Breaking change
  • Misc (docs, refactoring, dependency upgrade, etc.)

Check all that apply

  • This PR's description is comprehensive
  • This PR contains breaking changes that are documented in the description
  • This PR introduces new APIs or parameters that are documented and unlikely to change in the foreseeable future
  • This PR impacts documentation, and it has been updated (or a ticket has been logged)
  • This PR's changes are covered by the automated tests
  • This PR collects user input/sensitive content into Datadog
  • This PR passes the integration tests (ask a Datadog member to run the tests)
  • This PR passes the unit tests
  • This PR passes the installation tests (ask a Datadog member to run the tests)

@ktmq ktmq requested a review from a team as a code owner January 31, 2025 19:52
@github-actions github-actions bot added the aws label Jan 31, 2025
@ktmq ktmq changed the title Fix approval tests Fix approval tests and linter Jan 31, 2025
Copy link
Contributor

@ava-silver ava-silver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for getting on this!

@ktmq ktmq merged commit 6e3a156 into master Jan 31, 2025
12 checks passed
@ktmq ktmq deleted the katie.mckew/fix-tests branch January 31, 2025 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants