Adding comment to update datadog service name #899
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Service name should be something like azure-b2c-act-logs not "azure" which is too broad.
Update index.js
ava-silver
requested changes
Feb 14, 2025
ava-silver
approved these changes
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds a comment to remind users to change the service name from "azure" to other appropriate names confirming their internal naming convention as such. Service name "azure" is too broad. Other appropriate service name can be "azure-b2c-activity-logs"
Motivation
Makes it easier to have specific service name for specific needs. Removes confusion with service name.
Testing Guidelines
No code change
Additional Notes
Types of changes
Misc (docs, refactoring, dependency upgrade, etc.)
Check all that apply