[dogshell] enable proxy#415
Merged
zippolyte merged 2 commits intoDataDog:masterfrom Aug 27, 2019
ian28223:master
Merged
Conversation
gzussa
approved these changes
Jun 27, 2019
Contributor
gzussa
left a comment
gzussa
left a comment
There was a problem hiding this comment.
Seems legit to me. However could you add the motivation for this in the PR description
Contributor
Author
Done! And thanks for the approval! 🙇 |
zippolyte
suggested changes
Jul 29, 2019
Co-Authored-By: Hippolyte HENRY <zippolyte@users.noreply.github.com>
zippolyte
approved these changes
Jul 30, 2019
dabcoder
pushed a commit
to dabcoder/datadogpy
that referenced
this pull request
Oct 25, 2019
* [dogshell] enable proxy * Update datadog/dogshell/common.py Co-Authored-By: Hippolyte HENRY <zippolyte@users.noreply.github.com>
dabcoder
pushed a commit
to dabcoder/datadogpy
that referenced
this pull request
Nov 28, 2019
* [dogshell] enable proxy * Update datadog/dogshell/common.py Co-Authored-By: Hippolyte HENRY <zippolyte@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do
Allows for configuring a proxy for Dogshell.
sample ~/.dogrc that utilizes a proxy
Motivation
Someone asked in public slack how to use dogshell with a proxy.
Told him he could set
api_hostto a reverse proxy. Then, I looked at the code and found that dogshell usesdatadog.api.initializehere...and that
initializealready takes in proxies as a parameter here... so I figured I could just find a way pass the information from dogrc