Conversation
zippolyte
changed the title
dabcoder
approved these changes
Sep 26, 2019
|
Thanks for updating this! |
|
/azp run DataDog.datadogpy.integration |
|
Azure Pipelines successfully started running 1 pipeline(s). |
bkabrda
approved these changes
Sep 26, 2019
bkabrda
left a comment
bkabrda
left a comment
There was a problem hiding this comment.
Yup, urljoin behavior is somewhat confusing, so I'm +1 on this. LGTM!
dabcoder
pushed a commit
to dabcoder/datadogpy
that referenced
this pull request
Oct 25, 2019
dabcoder
pushed a commit
to dabcoder/datadogpy
that referenced
this pull request
Nov 28, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using
urljoinled to some unexpected results depending on whether there are leading/.Now uses a well defined and tested utility method, so no surprises