[MA-557] Add support for new `Monitor.can_delete` endpoint. by armcburney · Pull Request #474 · DataDog/datadogpy

armcburney · 2019-10-31T15:59:45Z

@DataDog/monitor-app

platinummonkey · 2019-10-31T16:12:37Z

/azp run DataDog.datadogpy.integration

azure-pipelines · 2019-10-31T16:12:46Z

Azure Pipelines successfully started running 1 pipeline(s).

platinummonkey · 2019-10-31T16:31:12Z

integration test failure is unrelated to this code ✅

armcburney · 2019-11-06T16:25:52Z

/azp run DataDog.datadogpy.integration

platinummonkey · 2019-11-07T13:54:53Z

/azp run DataDog.datadogpy.integration

nmuesch · 2019-11-07T16:45:54Z

/azp run DataDog.datadogpy.integration

nmuesch · 2019-11-07T16:48:36Z

/azp run

ofek · 2019-11-07T19:19:36Z

/azp run

platinummonkey · 2019-11-07T22:06:48Z

/azp please run? 🤣

zippolyte · 2019-11-08T09:26:26Z

It worked 😮

gzussa

The TestDatadog.test_monitor_can_delete integration test is failing.

nmuesch

Thanks! Looks good overall, left two minor comments

nmuesch · 2019-11-13T00:13:07Z

/azp run DataDog.datadogpy.integration

azure-pipelines · 2019-11-13T00:13:17Z

Azure Pipelines successfully started running 1 pipeline(s).

…` in dogshell.

…can_delete_endpoint

armcburney · 2019-11-25T16:57:32Z

/azp run DataDog.datadogpy.integration

azure-pipelines · 2019-11-25T16:57:41Z

Azure Pipelines successfully started running 1 pipeline(s).

armcburney · 2019-11-25T17:08:07Z

/azp run DataDog.datadogpy.integration

azure-pipelines · 2019-11-25T17:08:16Z

Azure Pipelines successfully started running 1 pipeline(s).

armcburney · 2019-11-25T17:53:57Z

/azp run DataDog.datadogpy.integration

azure-pipelines · 2019-11-25T17:54:06Z

Azure Pipelines successfully started running 1 pipeline(s).

armcburney · 2019-11-25T18:31:05Z

/azp run DataDog.datadogpy.integration

azure-pipelines · 2019-11-25T18:31:15Z

Azure Pipelines successfully started running 1 pipeline(s).

armcburney · 2019-11-25T19:24:29Z

/azp run DataDog.datadogpy.integration

azure-pipelines · 2019-11-25T19:24:38Z

Azure Pipelines successfully started running 1 pipeline(s).

armcburney · 2019-11-25T19:44:17Z

/azp run DataDog.datadogpy.integration

azure-pipelines · 2019-11-25T19:44:26Z

Azure Pipelines successfully started running 1 pipeline(s).

armcburney · 2019-11-25T19:56:46Z

Hi @nmuesch,

Could I get this change reviewed when you have the time please? The tests are flaky, and keep failing, but the tests related to my changes are ✅.

armcburney · 2019-11-25T21:45:39Z

/azp run DataDog.datadogpy.integration

azure-pipelines · 2019-11-25T21:45:49Z

Azure Pipelines successfully started running 1 pipeline(s).

Co-Authored-By: Jiri Kuncar <jiri.kuncar@datadoghq.com>

armcburney · 2019-11-26T18:08:31Z

/azp run DataDog.datadogpy.integration

azure-pipelines · 2019-11-26T18:08:41Z

Azure Pipelines successfully started running 1 pipeline(s).

armcburney · 2019-11-26T19:07:27Z

/azp run DataDog.datadogpy.integration

azure-pipelines · 2019-11-26T19:07:36Z

Azure Pipelines successfully started running 1 pipeline(s).

zippolyte · 2019-11-27T12:18:11Z

Merging, tests are flaky

[MA-557] Add support for new Monitor.can_delete endpoint.

835093c

armcburney requested a review from a team as a code owner October 31, 2019 15:59

[MA-557] Remove extra blank line.

74e96d0

platinummonkey approved these changes Oct 31, 2019

View reviewed changes

dabcoder reviewed Nov 6, 2019

View reviewed changes

Comment thread datadog/api/monitors.py

Comment thread datadog/dogshell/monitor.py

armcburney added 2 commits November 6, 2019 11:04

[MA-557] Add API integration test for Monitor.can_delete.

bb90223

[MA-557] Add integration test for dogshell Monitor.can_delete.

088c814

jd approved these changes Nov 6, 2019

View reviewed changes

armcburney mentioned this pull request Nov 6, 2019

[MA-554] Document the new Monitor.can_delete endpoint. DataDog/documentation#5856

Merged

gzussa requested a review from zippolyte November 8, 2019 12:26

gzussa suggested changes Nov 8, 2019

View reviewed changes

[MA-557] Fixed integration tests.

5be6552

armcburney requested a review from gzussa November 12, 2019 23:19

nmuesch suggested changes Nov 13, 2019

View reviewed changes

Comment thread tests/integration/api/test_api.py

Comment thread tests/integration/dogshell/test_dogshell.py Outdated

armcburney added 4 commits November 12, 2019 21:30

[MA-557] Delete the monitor at the end of the test_can_delete method.

6549120

[MA-557] Fix SLO create using dogshell, and fix tests for `can_delete…

890c05d

…` in dogshell.

Merge remote-tracking branch 'origin/master' into armcburney/monitor_…

a9049cb

…can_delete_endpoint

[MA-577] Create shared constant MONITOR_REFERENCED_IN_SLO_MESSAGE.

c073d54

jirikuncar reviewed Nov 26, 2019

View reviewed changes

Comment thread datadog/api/api_client.py Outdated

armcburney and others added 2 commits November 26, 2019 09:53

Update datadog/api/api_client.py

f0b7dbf

Co-Authored-By: Jiri Kuncar <jiri.kuncar@datadoghq.com>

Remove unused mapped_monitor_ids.

da5baea

jirikuncar approved these changes Nov 27, 2019

View reviewed changes

zippolyte merged commit 1dd2815 into master Nov 27, 2019

zippolyte deleted the armcburney/monitor_can_delete_endpoint branch November 27, 2019 12:18

Conversation

armcburney commented Oct 31, 2019

Uh oh!

platinummonkey commented Oct 31, 2019

Uh oh!

azure-pipelines Bot commented Oct 31, 2019

Uh oh!

platinummonkey commented Oct 31, 2019

Uh oh!

Uh oh!

Uh oh!

armcburney commented Nov 6, 2019

Uh oh!

platinummonkey commented Nov 7, 2019

Uh oh!

nmuesch commented Nov 7, 2019

Uh oh!

nmuesch commented Nov 7, 2019

Uh oh!

ofek commented Nov 7, 2019

Uh oh!

platinummonkey commented Nov 7, 2019

Uh oh!

zippolyte commented Nov 8, 2019

Uh oh!

gzussa left a comment

Choose a reason for hiding this comment

Uh oh!

nmuesch left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

nmuesch commented Nov 13, 2019

Uh oh!

azure-pipelines Bot commented Nov 13, 2019

Uh oh!

armcburney commented Nov 25, 2019

Uh oh!

azure-pipelines Bot commented Nov 25, 2019

Uh oh!

armcburney commented Nov 25, 2019

Uh oh!

azure-pipelines Bot commented Nov 25, 2019

Uh oh!

armcburney commented Nov 25, 2019

Uh oh!

azure-pipelines Bot commented Nov 25, 2019

Uh oh!

armcburney commented Nov 25, 2019

Uh oh!

azure-pipelines Bot commented Nov 25, 2019

Uh oh!

armcburney commented Nov 25, 2019

Uh oh!

azure-pipelines Bot commented Nov 25, 2019

Uh oh!

armcburney commented Nov 25, 2019

Uh oh!

azure-pipelines Bot commented Nov 25, 2019

Uh oh!

armcburney commented Nov 25, 2019

Uh oh!

armcburney commented Nov 25, 2019

Uh oh!

azure-pipelines Bot commented Nov 25, 2019

Uh oh!

Uh oh!

armcburney commented Nov 26, 2019

Uh oh!

azure-pipelines Bot commented Nov 26, 2019

Uh oh!

armcburney commented Nov 26, 2019

Uh oh!

azure-pipelines Bot commented Nov 26, 2019

Uh oh!

zippolyte commented Nov 27, 2019

Uh oh!

Reviewers

Assignees