Skip to content

[rabbitmq] Fixed #2905 - add ssl_verify option#2991

Merged
olivielpeau merged 1 commit intoDataDog:masterfrom
iancward:gh-2905
Nov 4, 2016
Merged

[rabbitmq] Fixed #2905 - add ssl_verify option#2991
olivielpeau merged 1 commit intoDataDog:masterfrom
iancward:gh-2905

Conversation

@iancward
Copy link
Contributor

@iancward iancward commented Nov 3, 2016

Note: Please remember to review the Datadog Contribution Guidelines
if you have not yet done so.

What does this PR do?

[rabbitmq] Fixes #2905 by adding ssl_verify instance config option, which can be used to skip ssl verification for API calls.

Motivation

We use a vendor app that bundles RabbitMQ using self-signed certificates, and we'd like to monitor it using Datadog.

Testing Guidelines

An overview on testing
is available in our contribution guidelines.

Additional Notes

I didn't add/change any tests for this, but I'd be willing to add some if I can get some guidance on it.

@masci masci added this to the Triage milestone Nov 4, 2016
@olivielpeau olivielpeau self-assigned this Nov 4, 2016
@olivielpeau olivielpeau modified the milestones: 5.10.0, Triage Nov 4, 2016
- This allows users to skip SSL verification for the RabbitMQ integration
Copy link
Member

@olivielpeau olivielpeau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @iancward! Changes look good, no need to add tests I think.

I've rebased your branch on top of the current master to include the CI fixes introduced by #2995

I'll merge as soon as the CI passes, thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants