[rabbitmq] Fixed #2905 - add ssl_verify option#2991
Merged
olivielpeau merged 1 commit intoDataDog:masterfrom Nov 4, 2016
Merged
[rabbitmq] Fixed #2905 - add ssl_verify option#2991olivielpeau merged 1 commit intoDataDog:masterfrom
olivielpeau merged 1 commit intoDataDog:masterfrom
Conversation
- This allows users to skip SSL verification for the RabbitMQ integration
olivielpeau
approved these changes
Nov 4, 2016
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: Please remember to review the Datadog Contribution Guidelines
if you have not yet done so.
What does this PR do?
[rabbitmq] Fixes #2905 by adding ssl_verify instance config option, which can be used to skip ssl verification for API calls.
Motivation
We use a vendor app that bundles RabbitMQ using self-signed certificates, and we'd like to monitor it using Datadog.
Testing Guidelines
An overview on testing
is available in our contribution guidelines.
Additional Notes
I didn't add/change any tests for this, but I'd be willing to add some if I can get some guidance on it.