[ANDROID] Specify locale for string case conversions #1009
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xnm
approved these changes
Oct 13, 2025
Thanks to @0xnm 💡 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR updates all
lowerCase()calls in the Android layer to explicitly specify a locale (usinglowerCase(Locale.US)).Motivation
Kotlin's
lowerCase()function is locale-sensitive. Without specifying a locale, it uses the system's default settings.This can lead to incorrect string conversions in certain locales, such as Turkish, where the lowercase form of "I" differs (
"INFO".lowerCase()becomes "ınfo" instead of "info").Review checklist (to be filled by reviewers)