Skip to content

RUM-4058: Fix build error when new architecture is enabled (Android) #654

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 29, 2024
Merged

RUM-4058: Fix build error when new architecture is enabled (Android) #654

merged 4 commits into from
Apr 29, 2024

Conversation

@marco-saia-datadog
Copy link
Member

@marco-saia-datadog marco-saia-datadog commented Apr 15, 2024 •
edited
Loading

What does this PR do?

Fixes a compilation issue that occurs when new architecture is enabled on Android. The issue has been introduced in version 2.3.0 with this commit: 2b259f5

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)
  • If this PR is auto-generated, please make sure also to manually update the code related to the change

@marco-saia-datadog marco-saia-datadog force-pushed the marcosaia/RUM-4058/new-arch-build-error branch from e6090aa to b25cbd8 Compare April 15, 2024 13:44
@marco-saia-datadog marco-saia-datadog force-pushed the marcosaia/RUM-4058/new-arch-build-error branch from b25cbd8 to 6299c9a Compare April 18, 2024 13:58
@marco-saia-datadog marco-saia-datadog marked this pull request as ready for review April 22, 2024 13:29
@marco-saia-datadog marco-saia-datadog requested a review from a team as a code owner April 22, 2024 13:29
@marco-saia-datadog marco-saia-datadog force-pushed the marcosaia/RUM-4058/new-arch-build-error branch from f2f8758 to 56afd4f Compare April 22, 2024 13:33
0xnm
0xnm reviewed Apr 22, 2024
View reviewed changes
@marco-saia-datadog marco-saia-datadog merged commit fa3a93e into develop Apr 29, 2024
@marco-saia-datadog marco-saia-datadog deleted the marcosaia/RUM-4058/new-arch-build-error branch April 29, 2024 09:06
This was referenced May 13, 2024
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fuzzybinary fuzzybinary fuzzybinary approved these changes

@0xnm 0xnm 0xnm approved these changes

@jonathanmos jonathanmos jonathanmos approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@marco-saia-datadog @fuzzybinary @0xnm @jonathanmos