Skip to content

[RUM-4303, RUM-4301]: Fix Android build error for RN v63 #660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 29, 2024
Merged

[RUM-4303, RUM-4301]: Fix Android build error for RN v63 #660

merged 1 commit into from
Apr 29, 2024

Conversation

@marco-saia-datadog
Copy link
Member

What does this PR do?

Fixes a build error that occurs when installing the latest version of Datadog React Native SDK in a project that uses react-native v63.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)
  • If this PR is auto-generated, please make sure also to manually update the code related to the change

@marco-saia-datadog marco-saia-datadog marked this pull request as ready for review April 29, 2024 08:57
@marco-saia-datadog marco-saia-datadog requested a review from a team as a code owner April 29, 2024 08:57
@marco-saia-datadog marco-saia-datadog changed the title RUM-4301: Fixed Android build error for RN v63 [RUM-4303, RUM-4301]: Fixed Android build error for RN v63 Apr 29, 2024
@marco-saia-datadog marco-saia-datadog changed the title [RUM-4303, RUM-4301]: Fixed Android build error for RN v63 [RUM-4303, RUM-4301]: Fix Android build error for RN v63 Apr 29, 2024
@marco-saia-datadog marco-saia-datadog merged commit 5b8a26c into develop Apr 29, 2024
@marco-saia-datadog marco-saia-datadog deleted the marcosaia/RUM-4301/fix-rn-63 branch April 29, 2024 09:20
@marco-saia-datadog marco-saia-datadog mentioned this pull request May 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@0xnm 0xnm 0xnm approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@marco-saia-datadog @0xnm