Fix span nesting on iOS #984
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbarrio
commented
Sep 12, 2025
| public func startSpan(operation: String, context: NSDictionary, timestampMs: Double, resolve:RCTPromiseResolveBlock, reject:RCTPromiseRejectBlock) -> Void { | ||
| let id = UUID().uuidString as NSString | ||
| objc_sync_enter(self) | ||
| defer { objc_sync_exit(self) } |
There was a problem hiding this comment.
This way we make sure that objc_sync will be released no matter what.
marco-saia-datadog
previously approved these changes
Sep 18, 2025
sbarrio
force-pushed
the
sbarrio/fix/get-span-nesting-to-work-on-ios
branch
from
293a5e8 to
539de5d
Compare
marco-saia-datadog
previously approved these changes
Oct 2, 2025
marco-saia-datadog
approved these changes
Oct 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes the implementation of DdTrace on iOS, so nesting spans is possible and displays properly on the Datadog dashboard.
Motivation
Span nesting works as expected on Android, but it does not on iOS, where spans appear registered separately, without taking into account if they have a parent span or not.
Additional Notes
Before
After
Review checklist (to be filled by reviewers)