Skip to content

Conversation

@mabdinur
Copy link
Contributor

@mabdinur mabdinur commented Nov 15, 2024

Description

  • Moves http_header extraction from /trace/span/start/ to a new trace/span/extract_headers endpoint. This ensures the /trace/span/start parametric endpoint aligns with the following specification.
  • Ensures /trace/span/finish does NOT clear the span list. Spans should only be removed from spans_ (previously active_spans_) if the trace/spans/flush is called.
  • R̶e̶n̶a̶m̶e̶s̶ ̶t̶h̶e̶ ̶̶a̶c̶t̶i̶v̶e̶_̶s̶p̶a̶n̶s̶_̶̶ ̶v̶a̶r̶i̶a̶b̶l̶e̶ ̶t̶o̶ ̶̶s̶p̶a̶n̶s̶_̶̶.̶ ̶T̶h̶i̶s̶ ̶m̶a̶p̶ ̶w̶i̶l̶l̶ ̶n̶o̶ ̶l̶o̶n̶g̶e̶r̶ ̶j̶u̶s̶t̶ ̶c̶o̶n̶t̶a̶i̶n̶ ̶a̶c̶t̶i̶v̶e̶ ̶s̶p̶a̶n̶s̶,̶ ̶i̶t̶ ̶w̶i̶l̶l̶ ̶a̶l̶s̶o̶ ̶s̶t̶o̶r̶e̶ ̶s̶p̶a̶n̶s̶ ̶e̶x̶t̶r̶a̶c̶t̶e̶d̶ ̶f̶r̶o̶m̶ ̶d̶i̶s̶t̶r̶i̶b̶u̶t̶e̶d̶ ̶t̶r̶a̶c̶i̶n̶g̶ ̶h̶e̶a̶d̶e̶r̶s̶.̶

Motivation

Additional Notes

Jira ticket: [PROJ-IDENT]

@pr-commenter
Copy link

pr-commenter bot commented Nov 15, 2024

Benchmarks

Benchmark execution time: 2025-01-20 14:02:43

Comparing candidate commit bb55ea9 in PR branch munir/update-parametric-app-start-span with baseline commit 3a8bcba in branch main.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics.

@mabdinur mabdinur force-pushed the munir/update-parametric-app-start-span branch from 418cd3d to b35ee1c Compare November 22, 2024 20:09
@codecov-commenter
Copy link

codecov-commenter commented Dec 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.91%. Comparing base (3a8bcba) to head (bb55ea9).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #170   +/-   ##
=======================================
  Coverage   93.91%   93.91%           
=======================================
  Files          73       73           
  Lines        4176     4176           
=======================================
  Hits         3922     3922           
  Misses        254      254           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mabdinur mabdinur force-pushed the munir/update-parametric-app-start-span branch from 7316007 to 1484a48 Compare December 23, 2024 20:49
@mabdinur mabdinur force-pushed the munir/update-parametric-app-start-span branch from 786889f to 1484a48 Compare January 3, 2025 18:34
@mabdinur mabdinur marked this pull request as ready for review January 14, 2025 20:57
@mabdinur mabdinur requested a review from a team as a code owner January 14, 2025 20:57
@mabdinur mabdinur requested review from dmehala and removed request for a team January 14, 2025 20:57
Copy link
Collaborator

@dmehala dmehala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I changed a bit the logic to avoid the endless if/else cascade and documented a bit the change.

@dmehala dmehala merged commit 6971362 into main Jan 20, 2025
21 checks passed
@dmehala dmehala deleted the munir/update-parametric-app-start-span branch January 20, 2025 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants