fix(telemetry): Handle empty configuration payload properly #186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fix addresses two issues: 1. Prevents invalid telemetry payloads when there are no configuration entries. 2. Ensures configuration updates are correctly processed and not carried over to the next update.
dmehala
requested review from
pablomartinezbernardo
and removed request for
a team
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #186 +/- ##
==========================================
- Coverage 93.80% 93.78% -0.02%
==========================================
Files 73 73
Lines 4195 4199 +4
==========================================
+ Hits 3935 3938 +3
- Misses 260 261 +1 ☔ View full report in Codecov by Sentry. |
pablomartinezbernardo
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This fix addresses two issues:
Motivation
Additional Notes
Jira ticket: [PROJ-IDENT]