Skip to content

Conversation

@andrewlock
Copy link
Member

Summary of changes

Fix issues that cause failure to compile if you try to use RC1

Reason for change

@bouwkast found these issues in #7499, but some people have already installed RC1 and are getting local failures, so this should unblock them

Implementation details

Copy the fixes from #7499

Test coverage

Covered by existing (hopefully)

Other details

@andrewlock andrewlock requested a review from a team as a code owner September 12, 2025 09:26
@github-actions github-actions bot added area:tracer The core tracer library (Datadog.Trace, does not include OpenTracing, native code, or integrations) area:debugger labels Sep 12, 2025
@dd-trace-dotnet-ci-bot
Copy link

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

  • Welch test with statistical test for significance of 5%
  • Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7506) - mean (72ms)  : 71, 73
     .   : milestone, 72,
    master - mean (72ms)  : 71, 73
     .   : milestone, 72,

    section Baseline
    This PR (7506) - mean (69ms)  : 64, 74
     .   : milestone, 69,
    master - mean (69ms)  : 64, 73
     .   : milestone, 69,

    section CallTarget+Inlining+NGEN
    This PR (7506) - mean (1,000ms)  : 970, 1029
     .   : milestone, 1000,
    master - mean (999ms)  : 969, 1028
     .   : milestone, 999,

Loading
gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7506) - mean (106ms)  : 105, 108
     .   : milestone, 106,
    master - mean (107ms)  : 105, 108
     .   : milestone, 107,

    section Baseline
    This PR (7506) - mean (106ms)  : 104, 108
     .   : milestone, 106,
    master - mean (106ms)  : 103, 108
     .   : milestone, 106,

    section CallTarget+Inlining+NGEN
    This PR (7506) - mean (701ms)  : 682, 721
     .   : milestone, 701,
    master - mean (701ms)  : 676, 725
     .   : milestone, 701,

Loading
gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7506) - mean (94ms)  : 93, 95
     .   : milestone, 94,
    master - mean (94ms)  : 93, 94
     .   : milestone, 94,

    section Baseline
    This PR (7506) - mean (94ms)  : 91, 96
     .   : milestone, 94,
    master - mean (93ms)  : 91, 95
     .   : milestone, 93,

    section CallTarget+Inlining+NGEN
    This PR (7506) - mean (658ms)  : 639, 676
     .   : milestone, 658,
    master - mean (660ms)  : 643, 678
     .   : milestone, 660,

Loading
gantt
    title Execution time (ms) FakeDbCommand (.NET 8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7506) - mean (93ms)  : 92, 94
     .   : milestone, 93,
    master - mean (93ms)  : 91, 94
     .   : milestone, 93,

    section Baseline
    This PR (7506) - mean (92ms)  : 90, 94
     .   : milestone, 92,
    master - mean (92ms)  : 89, 94
     .   : milestone, 92,

    section CallTarget+Inlining+NGEN
    This PR (7506) - mean (594ms)  : 583, 606
     .   : milestone, 594,
    master - mean (599ms)  : 584, 613
     .   : milestone, 599,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7506) - mean (198ms)  : 195, 201
     .   : milestone, 198,
    master - mean (196ms)  : 194, 199
     .   : milestone, 196,

    section Baseline
    This PR (7506) - mean (194ms)  : 190, 198
     .   : milestone, 194,
    master - mean (193ms)  : 187, 200
     .   : milestone, 193,

    section CallTarget+Inlining+NGEN
    This PR (7506) - mean (1,119ms)  : 1076, 1162
     .   : milestone, 1119,
    master - mean (1,112ms)  : 1079, 1146
     .   : milestone, 1112,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7506) - mean (280ms)  : 276, 284
     .   : milestone, 280,
    master - mean (278ms)  : 274, 283
     .   : milestone, 278,

    section Baseline
    This PR (7506) - mean (281ms)  : 275, 286
     .   : milestone, 281,
    master - mean (277ms)  : 272, 282
     .   : milestone, 277,

    section CallTarget+Inlining+NGEN
    This PR (7506) - mean (899ms)  : 871, 927
     .   : milestone, 899,
    master - mean (897ms)  : 864, 929
     .   : milestone, 897,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7506) - mean (273ms)  : 269, 277
     .   : milestone, 273,
    master - mean (270ms)  : 266, 273
     .   : milestone, 270,

    section Baseline
    This PR (7506) - mean (273ms)  : 269, 277
     .   : milestone, 273,
    master - mean (270ms)  : 265, 274
     .   : milestone, 270,

    section CallTarget+Inlining+NGEN
    This PR (7506) - mean (883ms)  : 852, 914
     .   : milestone, 883,
    master - mean (881ms)  : 848, 915
     .   : milestone, 881,

Loading
gantt
    title Execution time (ms) HttpMessageHandler (.NET 8) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Bailout
    This PR (7506) - mean (272ms)  : 268, 276
     .   : milestone, 272,
    master - mean (270ms)  : 265, 274
     .   : milestone, 270,

    section Baseline
    This PR (7506) - mean (272ms)  : 267, 277
     .   : milestone, 272,
    master - mean (268ms)  : 263, 273
     .   : milestone, 268,

    section CallTarget+Inlining+NGEN
    This PR (7506) - mean (795ms)  : 769, 821
     .   : milestone, 795,
    master - mean (792ms)  : 763, 821
     .   : milestone, 792,

Loading

@andrewlock andrewlock merged commit ccafd80 into master Sep 12, 2025
157 checks passed
@andrewlock andrewlock deleted the andrew/fix-rc1-issues branch September 12, 2025 11:54
@github-actions github-actions bot added this to the vNext-v3 milestone Sep 12, 2025
@zacharycmontoya zacharycmontoya changed the title Fix RC1 bugs Fix .NET 10 RC1 bugs Sep 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:debugger area:tracer The core tracer library (Datadog.Trace, does not include OpenTracing, native code, or integrations)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants