Skip to content

Commit 1ce3186

Browse files
[test optimization] Improve cucumber flakiness (#6833)
1 parent 34dac8c commit 1ce3186

File tree

2 files changed

+11
-2
lines changed

2 files changed

+11
-2
lines changed

integration-tests/cucumber/cucumber.spec.js

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1841,11 +1841,19 @@ versions.forEach(version => {
18411841
'./node_modules/.bin/cucumber-js ci-visibility/features-di/test-hit-breakpoint.feature --retry 1',
18421842
{
18431843
cwd,
1844-
env: envVars,
1844+
env: {
1845+
...envVars,
1846+
DD_TRACE_DEBUG: '1',
1847+
DD_TRACE_LOG_LEVEL: 'warn',
1848+
},
18451849
stdio: 'pipe'
18461850
}
18471851
)
18481852

1853+
// TODO: remove once we figure out flakiness
1854+
childProcess.stdout.pipe(process.stdout)
1855+
childProcess.stderr.pipe(process.stderr)
1856+
18491857
childProcess.on('exit', () => {
18501858
Promise.all([eventsPromise, logsPromise]).then(() => {
18511859
assert.equal(snapshotIdByTest, snapshotIdByLog)

packages/datadog-plugin-cucumber/src/index.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,8 @@ const {
5151
} = require('../../dd-trace/src/ci-visibility/telemetry')
5252

5353
const BREAKPOINT_HIT_GRACE_PERIOD_MS = 200
54-
const BREAKPOINT_SET_GRACE_PERIOD_MS = 200
54+
const BREAKPOINT_SET_GRACE_PERIOD_MS = 400
55+
5556
const isCucumberWorker = !!getEnvironmentVariable('CUCUMBER_WORKER_ID')
5657

5758
class CucumberPlugin extends CiPlugin {

0 commit comments

Comments
 (0)