Skip to content

Bug: Tracer ignores configured sampling rate #183

@atreidesend

Description

@atreidesend

It looks like the tracer constructed in opentracing/tracer.js is ignoring the configured sample rate and using a hardcoded value of 1

this._sampler = new Sampler(1)

Unless I'm missing something this samples everything, regardless of config. Happy to put together a quick PR to patch -> it could probably use something as simple config.sampleRate || 1

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions