Skip to content

fix graphql reference errors #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 29, 2018
Merged

fix graphql reference errors #165

merged 2 commits into from
Jun 29, 2018

Conversation

@rochdev
Copy link
Member

@rochdev rochdev commented Jun 28, 2018

This PR fixes the following reference errors in the graphql integration:

  • The field paths stored were invalid, causing the integration to crash when trying to retrieve the field span using its path
  • When an error was thrown by the graphql executor, it would cause the operation span to never be created. This caused a crash when trying to reference the operation span in the callback and prevented tracing the error.

@rochdev rochdev added bug Something isn't working integrations labels Jun 28, 2018
@rochdev rochdev added this to the 0.3.2 milestone Jun 28, 2018
@rochdev rochdev merged commit c23d979 into master Jun 29, 2018
@rochdev rochdev deleted the fix-graphql-spans branch June 29, 2018 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vinvol vinvol vinvol approved these changes

Assignees

No one assigned

Labels

bug Something isn't working integrations

Projects

None yet

Milestone

0.3.2

Development

Successfully merging this pull request may close these issues.

3 participants

@rochdev @vinvol