fix scope manager being instantiated multiple times #188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rochdev
force-pushed
the
scope-manager-singleton
branch
from
2b1db0b to
164d957
Compare
rochdev
force-pushed
the
scope-manager-singleton
branch
from
121f231 to
d6d99e4
Compare
vinvol
approved these changes
Jul 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the scope manager being instantiated multiple times. Once a scope manager has been created, there should only ever be a single one to avoid attaching hooks multiple times.
It also fixes the
mysqlandmysql2integrations missing the parent scope in their respective callbacks. It seems the way tests were setup before the scope manager fix was hiding this bug.