-
Notifications
You must be signed in to change notification settings - Fork 358
waf requests telemetry metrics #5384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Overall package sizeSelf size: 9.09 MB Dependency sizes| name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.5.0 | 29.83 MB | 29.83 MB | | @datadog/native-appsec | 8.5.1 | 19.26 MB | 19.27 MB | | @datadog/native-iast-taint-tracking | 3.3.0 | 13.77 MB | 13.78 MB | | @datadog/pprof | 5.6.0 | 9.79 MB | 10.16 MB | | @opentelemetry/core | 1.30.1 | 908.66 kB | 7.16 MB | | protobufjs | 7.4.0 | 2.77 MB | 5.42 MB | | @datadog/native-iast-rewriter | 2.8.0 | 2.6 MB | 2.74 MB | | @datadog/native-metrics | 3.1.0 | 1.06 MB | 1.46 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.13.1 | 117.64 kB | 839.26 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.1 | 109.9 kB | 109.9 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.2 | 53.63 kB | 53.63 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.4.1 | 27.15 kB | 27.15 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | dc-polyfill | 0.1.6 | 24.56 kB | 24.56 kB | | shell-quote | 1.8.2 | 23.54 kB | 23.54 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | semifies | 1.0.0 | 15.84 kB | 15.84 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |🤖 This report was automatically generated by heaviest-objects-in-the-universe |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5384 +/- ##
==========================================
- Coverage 79.56% 79.31% -0.26%
==========================================
Files 510 510
Lines 22898 23038 +140
==========================================
+ Hits 18219 18272 +53
- Misses 4679 4766 +87 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Datadog ReportBranch report: ✅ 0 Failed, 914 Passed, 0 Skipped, 9m 45.43s Total Time |
BenchmarksBenchmark execution time: 2025-03-25 13:31:47 Comparing candidate commit f81fc9b in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 918 metrics, 15 unstable metrics. |
5538f28 to
482d1ce
Compare
|
Code LGTM but do we have system tests validating this ? |
|
Here is a pending PR https://github.com/DataDog/system-tests/pull/4354/files, test is good locally. |
* waf requests telemetry metrics * fix undefined versions * add more tests * fix tags order * update waf metrics integration test * remove duplicate input_truncated on test * fix waf requests telemtry test * fix rate limiter * report waf error metric * fix updateWafRateLimitedMetric reporter test * fix functions order * change function names * add versions to report attack * fix reporting rate limiting metric
* waf requests telemetry metrics * fix undefined versions * add more tests * fix tags order * update waf metrics integration test * remove duplicate input_truncated on test * fix waf requests telemtry test * fix rate limiter * report waf error metric * fix updateWafRateLimitedMetric reporter test * fix functions order * change function names * add versions to report attack * fix reporting rate limiting metric
* tag 'v5.45.0': (141 commits) v5.45.0 fix duplicate custom metrics when multiple tags are used (DataDog#5491) report rc.client_id tag when rc is enabled (DataDog#5467) add sdk.event to communicate a login or custom event (DataDog#5462) add matrix strategy to debugger ci job (DataDog#5450) chore(llmobs): add telemetry metrics for dropped span/eval payloads (DataDog#5469) chore(llmobs): Add llmobs product enabled telemetry metrics (DataDog#5475) chore(langchain): fix test flakiness (DataDog#5461) v5.44.0 Fix iast flaky code injection tests (DataDog#5460) Add a few TODO's (DataDog#5477) chore(llmobs): add span size telemetry metrics (DataDog#5468) fix memory leak in runtime.node.heap.* metrics (DataDog#5476) waf requests telemetry metrics (DataDog#5384) feat(llmobs): add vertexai plugin (DataDog#5413) Fix logging null when debugging and sending data without any error (DataDog#5480) [test optimization] [SDTEST-1720] Change capabilities tagging to send version number (DataDog#5463) [test optimization] [SDTEST-1630] Attempt to fix flaky tests implementation (DataDog#5429) fix wrong test error message when expected span was not received (DataDog#5447) make cache action unix compatible and update test agent (DataDog#5464) ...
What does this PR do?
Add new tags for waf.requests metric APPSEC-56973 :
block_failurerate_limitedwaf_errorwaf.errorPlugin Checklist
Additional Notes