Skip to content

Conversation

@IlyasShabi
Copy link
Contributor

@IlyasShabi IlyasShabi commented Mar 10, 2025

What does this PR do?

Add new tags for waf.requests metric APPSEC-56973 :

  • block_failure
  • rate_limited
  • waf_error
  • waf.error

Plugin Checklist

Additional Notes

@github-actions
Copy link

github-actions bot commented Mar 10, 2025

Overall package size

Self size: 9.09 MB
Deduped: 101.62 MB
No deduping: 102.14 MB

Dependency sizes | name | version | self size | total size | |------|---------|-----------|------------| | @datadog/libdatadog | 0.5.0 | 29.83 MB | 29.83 MB | | @datadog/native-appsec | 8.5.1 | 19.26 MB | 19.27 MB | | @datadog/native-iast-taint-tracking | 3.3.0 | 13.77 MB | 13.78 MB | | @datadog/pprof | 5.6.0 | 9.79 MB | 10.16 MB | | @opentelemetry/core | 1.30.1 | 908.66 kB | 7.16 MB | | protobufjs | 7.4.0 | 2.77 MB | 5.42 MB | | @datadog/native-iast-rewriter | 2.8.0 | 2.6 MB | 2.74 MB | | @datadog/native-metrics | 3.1.0 | 1.06 MB | 1.46 MB | | @opentelemetry/api | 1.8.0 | 1.21 MB | 1.21 MB | | import-in-the-middle | 1.13.1 | 117.64 kB | 839.26 kB | | source-map | 0.7.4 | 226 kB | 226 kB | | opentracing | 0.14.7 | 194.81 kB | 194.81 kB | | lru-cache | 7.18.3 | 133.92 kB | 133.92 kB | | pprof-format | 2.1.0 | 111.69 kB | 111.69 kB | | @datadog/sketches-js | 2.1.1 | 109.9 kB | 109.9 kB | | lodash.sortby | 4.7.0 | 75.76 kB | 75.76 kB | | ignore | 5.3.2 | 53.63 kB | 53.63 kB | | istanbul-lib-coverage | 3.2.0 | 29.34 kB | 29.34 kB | | rfdc | 1.4.1 | 27.15 kB | 27.15 kB | | @isaacs/ttlcache | 1.4.1 | 25.2 kB | 25.2 kB | | tlhunter-sorted-set | 0.1.0 | 24.94 kB | 24.94 kB | | dc-polyfill | 0.1.6 | 24.56 kB | 24.56 kB | | shell-quote | 1.8.2 | 23.54 kB | 23.54 kB | | limiter | 1.1.5 | 23.17 kB | 23.17 kB | | retry | 0.13.1 | 18.85 kB | 18.85 kB | | semifies | 1.0.0 | 15.84 kB | 15.84 kB | | jest-docblock | 29.7.0 | 8.99 kB | 12.76 kB | | crypto-randomuuid | 1.0.0 | 11.18 kB | 11.18 kB | | ttl-set | 1.0.0 | 4.61 kB | 9.69 kB | | path-to-regexp | 0.1.12 | 6.6 kB | 6.6 kB | | koalas | 1.0.2 | 6.47 kB | 6.47 kB | | module-details-from-path | 1.0.3 | 4.47 kB | 4.47 kB |

🤖 This report was automatically generated by heaviest-objects-in-the-universe

@codecov
Copy link

codecov bot commented Mar 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.31%. Comparing base (604cfa0) to head (f81fc9b).
Report is 19 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5384      +/-   ##
==========================================
- Coverage   79.56%   79.31%   -0.26%     
==========================================
  Files         510      510              
  Lines       22898    23038     +140     
==========================================
+ Hits        18219    18272      +53     
- Misses       4679     4766      +87     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@datadog-datadog-prod-us1
Copy link

datadog-datadog-prod-us1 bot commented Mar 10, 2025

Datadog Report

Branch report: ishabi/waf-requests-telemetry
Commit report: 3ac3d58
Test service: dd-trace-js-integration-tests

✅ 0 Failed, 914 Passed, 0 Skipped, 9m 45.43s Total Time

@pr-commenter
Copy link

pr-commenter bot commented Mar 10, 2025

Benchmarks

Benchmark execution time: 2025-03-25 13:31:47

Comparing candidate commit f81fc9b in PR branch ishabi/waf-requests-telemetry with baseline commit 604cfa0 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 918 metrics, 15 unstable metrics.

@IlyasShabi IlyasShabi marked this pull request as ready for review March 10, 2025 14:51
@IlyasShabi IlyasShabi requested a review from a team as a code owner March 10, 2025 14:51
@IlyasShabi IlyasShabi requested a review from uurien March 18, 2025 12:33
@IlyasShabi IlyasShabi marked this pull request as draft March 19, 2025 08:57
@IlyasShabi IlyasShabi force-pushed the ishabi/waf-requests-telemetry branch from 5538f28 to 482d1ce Compare March 19, 2025 09:28
@IlyasShabi IlyasShabi requested a review from simon-id March 19, 2025 14:15
@IlyasShabi IlyasShabi marked this pull request as ready for review March 19, 2025 14:15
@simon-id
Copy link
Member

Code LGTM but do we have system tests validating this ?

@IlyasShabi
Copy link
Contributor Author

Here is a pending PR https://github.com/DataDog/system-tests/pull/4354/files, test is good locally.
I will add nodejs after dd-trace new release

@IlyasShabi IlyasShabi requested a review from simon-id March 21, 2025 10:03
@IlyasShabi IlyasShabi marked this pull request as draft March 25, 2025 13:16
@IlyasShabi IlyasShabi marked this pull request as ready for review March 25, 2025 13:33
@IlyasShabi IlyasShabi merged commit d1d7ccf into master Mar 25, 2025
430 checks passed
@IlyasShabi IlyasShabi deleted the ishabi/waf-requests-telemetry branch March 25, 2025 14:32
@rochdev rochdev mentioned this pull request Mar 26, 2025
rochdev pushed a commit that referenced this pull request Mar 26, 2025
* waf requests telemetry metrics

* fix undefined versions

* add more tests

* fix tags order

* update waf metrics integration test

* remove duplicate input_truncated on test

* fix waf requests telemtry test

* fix rate limiter

* report waf error metric

* fix updateWafRateLimitedMetric reporter test

* fix functions order

* change function names

* add versions to report attack

* fix reporting rate limiting metric
rochdev pushed a commit that referenced this pull request Mar 26, 2025
* waf requests telemetry metrics

* fix undefined versions

* add more tests

* fix tags order

* update waf metrics integration test

* remove duplicate input_truncated on test

* fix waf requests telemtry test

* fix rate limiter

* report waf error metric

* fix updateWafRateLimitedMetric reporter test

* fix functions order

* change function names

* add versions to report attack

* fix reporting rate limiting metric
papandreou added a commit to papandreou/dd-trace-js that referenced this pull request Apr 2, 2025
* tag 'v5.45.0': (141 commits)
  v5.45.0
  fix duplicate custom metrics when multiple tags are used (DataDog#5491)
  report rc.client_id tag when rc is enabled (DataDog#5467)
  add sdk.event to communicate a login or custom event (DataDog#5462)
  add matrix strategy to debugger ci job (DataDog#5450)
  chore(llmobs): add telemetry metrics for dropped span/eval payloads (DataDog#5469)
  chore(llmobs): Add llmobs product enabled telemetry metrics (DataDog#5475)
  chore(langchain): fix test flakiness (DataDog#5461)
  v5.44.0
  Fix iast flaky code injection tests (DataDog#5460)
  Add a few TODO's (DataDog#5477)
  chore(llmobs): add span size telemetry metrics (DataDog#5468)
  fix memory leak in runtime.node.heap.* metrics (DataDog#5476)
  waf requests telemetry metrics (DataDog#5384)
  feat(llmobs): add vertexai plugin (DataDog#5413)
  Fix logging null when debugging and sending data without any error (DataDog#5480)
  [test optimization] [SDTEST-1720] Change capabilities tagging to send version number (DataDog#5463)
  [test optimization] [SDTEST-1630] Attempt to fix flaky tests implementation (DataDog#5429)
  fix wrong test error message when expected span was not received (DataDog#5447)
  make cache action unix compatible and update test agent (DataDog#5464)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants