Use zend_execute_internal on PHP 5.6 #903

morrisonlevi · 2020-05-26T15:58:11Z

This PR:

Splits some of the sources for PHP 5.4 off into a php5_4 folder (fun note, you can't name that folder php5.4 or the build will fail).
Removes some version-specific in php5/engine_hooks.c that is now unused since PHP 5.4 doesn't use that file anymore. However, I did not do the equivalent task for php5_4/engine_hooks.c because every time I did this I broke the build.
Uses zend_execute_internal for PHP 5.6. This fixes an issue in labbati/noop-api when PDO::ATTR_STATEMENT_CLASS is used.

This is targeting labbati/noop-api instead of master.

This specific commit does not reduce ifdefs; this will happen next.

Intentionally leave PHP 5.4 alone.

morrisonlevi added 3 commits May 26, 2020 09:15

Split PHP 5.4 sources

30f9cc5

This specific commit does not reduce ifdefs; this will happen next.

Remove PHP version specific branches in PHP 5.6

1981d1a

Intentionally leave PHP 5.4 alone.

Implement zend_execute_internal on PHP 5.6

532d344

morrisonlevi merged commit 6c609cc into labbati/noop-api May 26, 2020

morrisonlevi deleted the levi/zend_execute_internal-5.6 branch May 26, 2020 15:58

Provide feedback