Skip to content

Conversation

@majorgreys
Copy link
Contributor

@majorgreys majorgreys commented Jan 9, 2020

Since 0.32.0, the vendored debtcollector depends on funcsigs before Python 3.3 but this had not been specified for installation at setup, causing an ImportError exception when importing ddtrace or running ddtrace-run on Python 2.7 if funcsigs had not been installed as a dependency of another library.

@majorgreys majorgreys requested a review from a team as a code owner January 9, 2020 22:15
lucaspimentel
lucaspimentel previously approved these changes Jan 9, 2020
Copy link
Member

@lucaspimentel lucaspimentel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rubber stamp

brettlangdon
brettlangdon previously approved these changes Jan 9, 2020
@brettlangdon brettlangdon merged commit a2f1697 into master Jan 9, 2020
@brettlangdon brettlangdon deleted the majorgreys/funcsigs branch January 9, 2020 23:20
@majorgreys majorgreys added this to the 0.33.0 milestone Jan 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants