fix(tests,profile): do not test the number of locking events #1282
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This test can be false in Python 2.7 (at least) since it's possible that we catch the profiler background thread using a lock — the Python 2 threading module uses one. Only do a check based on the lock name, that ought to be enough.
brettlangdon
approved these changes
Mar 18, 2020
Contributor
Author
|
Opened #1285 for the test failure on |
codeboten
pushed a commit
to lightstep/ls-trace-py
that referenced
this pull request
Mar 19, 2020
…#1282) This test can be false in Python 2.7 (at least) since it's possible that we catch the profiler background thread using a lock — the Python 2 threading module uses one. Only do a check based on the lock name, that ought to be enough.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test can be false in Python 2.7 (at least) since it's possible that we
catch the profiler background thread using a lock — the Python 2 threading
module uses one.
Only do a check based on the lock name, that ought to be enough.