-
Notifications
You must be signed in to change notification settings - Fork 464
chore: remove opentracer package #14892
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 239 ± 2 ms. The average import time from base is: 241 ± 2 ms. The import time difference between this PR and base is: -2.49 ± 0.09 ms. Import time breakdownThe following import paths have shrunk:
|
Performance SLOsComparing candidate remove-opentracer (2db7193) with baseline 4.0-breaking-changes (c68dcb4) 📈 Performance Regressions (2 suites)📈 iastaspectsospath - 24/24✅ ospathbasename_aspectTime: ✅ 4.387µs (SLO: <10.000µs 📉 -56.1%) vs baseline: +2.5% Memory: ✅ 37.690MB (SLO: <39.000MB -3.4%) vs baseline: +4.9% ✅ ospathbasename_noaspectTime: ✅ 1.089µs (SLO: <10.000µs 📉 -89.1%) vs baseline: -0.4% Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +4.9% ✅ ospathjoin_aspectTime: ✅ 6.257µs (SLO: <10.000µs 📉 -37.4%) vs baseline: +0.7% Memory: ✅ 37.690MB (SLO: <39.000MB -3.4%) vs baseline: +4.8% ✅ ospathjoin_noaspectTime: ✅ 2.327µs (SLO: <10.000µs 📉 -76.7%) vs baseline: +0.1% Memory: ✅ 37.709MB (SLO: <39.000MB -3.3%) vs baseline: +5.0% ✅ ospathnormcase_aspectTime: ✅ 3.979µs (SLO: <10.000µs 📉 -60.2%) vs baseline: 📈 +10.5% Memory: ✅ 37.631MB (SLO: <39.000MB -3.5%) vs baseline: +4.7% ✅ ospathnormcase_noaspectTime: ✅ 0.566µs (SLO: <10.000µs 📉 -94.3%) vs baseline: -1.8% Memory: ✅ 37.709MB (SLO: <39.000MB -3.3%) vs baseline: +4.8% ✅ ospathsplit_aspectTime: ✅ 5.028µs (SLO: <10.000µs 📉 -49.7%) vs baseline: +2.6% Memory: ✅ 37.690MB (SLO: <39.000MB -3.4%) vs baseline: +4.9% ✅ ospathsplit_noaspectTime: ✅ 1.603µs (SLO: <10.000µs 📉 -84.0%) vs baseline: +0.8% Memory: ✅ 37.709MB (SLO: <39.000MB -3.3%) vs baseline: +5.0% ✅ ospathsplitdrive_aspectTime: ✅ 3.776µs (SLO: <10.000µs 📉 -62.2%) vs baseline: +0.6% Memory: ✅ 37.611MB (SLO: <39.000MB -3.6%) vs baseline: +4.7% ✅ ospathsplitdrive_noaspectTime: ✅ 0.693µs (SLO: <10.000µs 📉 -93.1%) vs baseline: -1.8% Memory: ✅ 37.709MB (SLO: <39.000MB -3.3%) vs baseline: +5.0% ✅ ospathsplitext_aspectTime: ✅ 4.632µs (SLO: <10.000µs 📉 -53.7%) vs baseline: +1.1% Memory: ✅ 37.670MB (SLO: <39.000MB -3.4%) vs baseline: +5.1% ✅ ospathsplitext_noaspectTime: ✅ 1.387µs (SLO: <10.000µs 📉 -86.1%) vs baseline: +0.4% Memory: ✅ 37.709MB (SLO: <39.000MB -3.3%) vs baseline: +5.0% 📈 telemetryaddmetric - 30/30✅ 1-count-metric-1-timesTime: ✅ 2.998µs (SLO: <20.000µs 📉 -85.0%) vs baseline: +2.0% Memory: ✅ 32.086MB (SLO: <34.000MB -5.6%) vs baseline: +4.9% ✅ 1-count-metrics-100-timesTime: ✅ 207.247µs (SLO: <220.000µs -5.8%) vs baseline: +2.4% Memory: ✅ 32.126MB (SLO: <34.000MB -5.5%) vs baseline: +4.9% ✅ 1-distribution-metric-1-timesTime: ✅ 3.349µs (SLO: <20.000µs 📉 -83.3%) vs baseline: +0.9% Memory: ✅ 32.106MB (SLO: <34.000MB -5.6%) vs baseline: +4.7% ✅ 1-distribution-metrics-100-timesTime: ✅ 219.360µs (SLO: <220.000µs 🟡 -0.3%) vs baseline: +2.6% Memory: ✅ 32.106MB (SLO: <34.000MB -5.6%) vs baseline: +4.5% ✅ 1-gauge-metric-1-timesTime: ✅ 2.422µs (SLO: <20.000µs 📉 -87.9%) vs baseline: 📈 +10.5% Memory: ✅ 32.185MB (SLO: <34.000MB -5.3%) vs baseline: +4.9% ✅ 1-gauge-metrics-100-timesTime: ✅ 137.090µs (SLO: <150.000µs -8.6%) vs baseline: -0.4% Memory: ✅ 32.185MB (SLO: <34.000MB -5.3%) vs baseline: +5.0% ✅ 1-rate-metric-1-timesTime: ✅ 3.117µs (SLO: <20.000µs 📉 -84.4%) vs baseline: +1.5% Memory: ✅ 32.145MB (SLO: <34.000MB -5.5%) vs baseline: +4.9% ✅ 1-rate-metrics-100-timesTime: ✅ 222.559µs (SLO: <250.000µs 📉 -11.0%) vs baseline: +3.2% Memory: ✅ 32.145MB (SLO: <34.000MB -5.5%) vs baseline: +4.9% ✅ 100-count-metrics-100-timesTime: ✅ 20.453ms (SLO: <22.000ms -7.0%) vs baseline: -0.4% Memory: ✅ 32.165MB (SLO: <34.000MB -5.4%) vs baseline: +5.0% ✅ 100-distribution-metrics-100-timesTime: ✅ 2.264ms (SLO: <2.300ms 🟡 -1.6%) vs baseline: -0.8% Memory: ✅ 32.145MB (SLO: <34.000MB -5.5%) vs baseline: +4.9% ✅ 100-gauge-metrics-100-timesTime: ✅ 1.410ms (SLO: <1.550ms -9.0%) vs baseline: +1.1% Memory: ✅ 32.145MB (SLO: <34.000MB -5.5%) vs baseline: +4.8% ✅ 100-rate-metrics-100-timesTime: ✅ 2.211ms (SLO: <2.550ms 📉 -13.3%) vs baseline: ~same Memory: ✅ 32.145MB (SLO: <34.000MB -5.5%) vs baseline: +4.9% ✅ flush-1-metricTime: ✅ 4.703µs (SLO: <20.000µs 📉 -76.5%) vs baseline: +6.0% Memory: ✅ 32.165MB (SLO: <34.000MB -5.4%) vs baseline: +4.7% ✅ flush-100-metricsTime: ✅ 174.611µs (SLO: <250.000µs 📉 -30.2%) vs baseline: +0.3% Memory: ✅ 32.106MB (SLO: <34.000MB -5.6%) vs baseline: +4.6% ✅ flush-1000-metricsTime: ✅ 2.120ms (SLO: <2.500ms 📉 -15.2%) vs baseline: +0.2% Memory: ✅ 32.873MB (SLO: <34.500MB -4.7%) vs baseline: +4.7% 🟡 Near SLO Breach (3 suites)🟡 djangosimple - 30/30✅ appsecTime: ✅ 20.428ms (SLO: <22.300ms -8.4%) vs baseline: ~same Memory: ✅ 65.221MB (SLO: <67.000MB -2.7%) vs baseline: +4.9% ✅ exception-replay-enabledTime: ✅ 1.342ms (SLO: <1.450ms -7.5%) vs baseline: +0.5% Memory: ✅ 64.675MB (SLO: <67.000MB -3.5%) vs baseline: +4.9% ✅ iastTime: ✅ 20.464ms (SLO: <22.250ms -8.0%) vs baseline: ~same Memory: ✅ 65.245MB (SLO: <67.000MB -2.6%) vs baseline: +4.9% ✅ profilerTime: ✅ 15.272ms (SLO: <16.550ms -7.7%) vs baseline: +0.4% Memory: ✅ 53.831MB (SLO: <54.500MB 🟡 -1.2%) vs baseline: +4.9% ✅ resource-renamingTime: ✅ 20.538ms (SLO: <21.750ms -5.6%) vs baseline: -0.1% Memory: ✅ 65.201MB (SLO: <67.000MB -2.7%) vs baseline: +4.8% ✅ span-code-originTime: ✅ 25.345ms (SLO: <28.200ms 📉 -10.1%) vs baseline: -0.2% Memory: ✅ 67.518MB (SLO: <69.500MB -2.9%) vs baseline: +4.7% ✅ tracerTime: ✅ 20.457ms (SLO: <21.750ms -5.9%) vs baseline: +0.2% Memory: ✅ 65.220MB (SLO: <67.000MB -2.7%) vs baseline: +4.8% ✅ tracer-and-profilerTime: ✅ 22.015ms (SLO: <23.500ms -6.3%) vs baseline: -0.1% Memory: ✅ 66.688MB (SLO: <67.500MB 🟡 -1.2%) vs baseline: +4.9% ✅ tracer-dont-create-db-spansTime: ✅ 19.332ms (SLO: <21.500ms 📉 -10.1%) vs baseline: +0.5% Memory: ✅ 65.147MB (SLO: <66.000MB 🟡 -1.3%) vs baseline: +4.7% ✅ tracer-minimalTime: ✅ 16.597ms (SLO: <17.500ms -5.2%) vs baseline: -0.4% Memory: ✅ 65.199MB (SLO: <66.000MB 🟡 -1.2%) vs baseline: +4.8% ✅ tracer-nativeTime: ✅ 20.413ms (SLO: <21.750ms -6.1%) vs baseline: -0.1% Memory: ✅ 71.034MB (SLO: <72.500MB -2.0%) vs baseline: +4.6% ✅ tracer-no-cachesTime: ✅ 18.464ms (SLO: <19.650ms -6.0%) vs baseline: ~same Memory: ✅ 65.253MB (SLO: <67.000MB -2.6%) vs baseline: +4.9% ✅ tracer-no-databasesTime: ✅ 18.828ms (SLO: <20.100ms -6.3%) vs baseline: +0.6% Memory: ✅ 65.237MB (SLO: <67.000MB -2.6%) vs baseline: +4.9% ✅ tracer-no-middlewareTime: ✅ 20.191ms (SLO: <21.500ms -6.1%) vs baseline: +0.4% Memory: ✅ 65.265MB (SLO: <67.000MB -2.6%) vs baseline: +5.0% ✅ tracer-no-templatesTime: ✅ 20.288ms (SLO: <22.000ms -7.8%) vs baseline: +0.4% Memory: ✅ 65.184MB (SLO: <67.000MB -2.7%) vs baseline: +4.8% 🟡 errortrackingdjangosimple - 6/6✅ errortracking-enabled-allTime: ✅ 18.063ms (SLO: <19.850ms -9.0%) vs baseline: +0.3% Memory: ✅ 65.192MB (SLO: <66.500MB 🟡 -2.0%) vs baseline: +5.0% ✅ errortracking-enabled-userTime: ✅ 18.207ms (SLO: <19.400ms -6.2%) vs baseline: +0.9% Memory: ✅ 65.176MB (SLO: <66.500MB 🟡 -2.0%) vs baseline: +5.0% ✅ tracer-enabledTime: ✅ 18.120ms (SLO: <19.450ms -6.8%) vs baseline: +0.4% Memory: ✅ 65.254MB (SLO: <66.500MB 🟡 -1.9%) vs baseline: +4.8% 🟡 flasksimple - 18/18✅ appsec-getTime: ✅ 4.578ms (SLO: <4.750ms -3.6%) vs baseline: ~same Memory: ✅ 62.049MB (SLO: <65.000MB -4.5%) vs baseline: +4.9% ✅ appsec-postTime: ✅ 6.607ms (SLO: <6.750ms -2.1%) vs baseline: -0.2% Memory: ✅ 61.991MB (SLO: <65.000MB -4.6%) vs baseline: +4.8% ✅ appsec-telemetryTime: ✅ 4.580ms (SLO: <4.750ms -3.6%) vs baseline: ~same Memory: ✅ 61.991MB (SLO: <65.000MB -4.6%) vs baseline: +4.9% ✅ debuggerTime: ✅ 1.857ms (SLO: <2.000ms -7.2%) vs baseline: +0.2% Memory: ✅ 45.475MB (SLO: <47.000MB -3.2%) vs baseline: +4.9% ✅ iast-getTime: ✅ 1.858ms (SLO: <2.000ms -7.1%) vs baseline: ~same Memory: ✅ 42.448MB (SLO: <49.000MB 📉 -13.4%) vs baseline: +4.9% ✅ profilerTime: ✅ 1.912ms (SLO: <2.100ms -8.9%) vs baseline: ~same Memory: ✅ 46.517MB (SLO: <47.000MB 🟡 -1.0%) vs baseline: +4.9% ✅ resource-renamingTime: ✅ 3.368ms (SLO: <3.650ms -7.7%) vs baseline: ~same Memory: ✅ 52.278MB (SLO: <53.500MB -2.3%) vs baseline: +4.9% ✅ tracerTime: ✅ 3.352ms (SLO: <3.650ms -8.2%) vs baseline: ~same Memory: ✅ 52.160MB (SLO: <53.500MB -2.5%) vs baseline: +4.7% ✅ tracer-nativeTime: ✅ 3.354ms (SLO: <3.650ms -8.1%) vs baseline: -0.1% Memory: ✅ 58.223MB (SLO: <60.000MB -3.0%) vs baseline: +4.5%
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, I was just doing this myself... glad I found your pr 😅
1e1dda5
into
4.0-breaking-changes
This change removes the deprecated
opentracerpackage from ddtrace.Note the base branch, a staging area for breaking changes slated for 4.0.