Skip to content

fix: ensure IPC file closed after use #15194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 10, 2025
Merged

fix: ensure IPC file closed after use #15194

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
15f1161
fix: ensure IPC file closed after use
P403n1x87 Nov 10, 2025
4dadca0
Merge branch 'main' into fix/ipc-open-file-ensure-closed
P403n1x87 Nov 10, 2025
e1267f2
Merge branch 'main' into fix/ipc-open-file-ensure-closed
P403n1x87 Nov 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions ddtrace/internal/ipc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
from contextlib import contextmanager
import os
import secrets
import tempfile
Expand Down Expand Up @@ -57,9 +56,7 @@ class ReadLock(BaseUnixLock):
class WriteLock(BaseUnixLock):
__acquire_mode__ = fcntl.LOCK_EX

@contextmanager
def open_file(path, mode):
yield unpatched_open(path, mode)
open_file = unpatched_open

except ModuleNotFoundError:
# Availability: Windows
Expand All @@ -78,7 +75,7 @@ def release(self):

ReadLock = WriteLock = BaseWinLock # type: ignore

def open_file(path, mode):
def open_file(path, mode): # type: ignore
import _winapi

# force all modes to be read/write binary
Expand Down
4 changes: 4 additions & 0 deletions releasenotes/notes/fix-ipc-open-file-ensure-closed-98d9707f56c416da.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
---
fixes:
- |
Prevent a potential ``ResourceWarning`` in multiprocess scenarios.
Loading