-
Notifications
You must be signed in to change notification settings - Fork 470
chore: retry flares cleanup on tests to remove flakiness on CI #15198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Juanjo Alvarez <juanjo.alvarezmartinez@datadoghq.com>
|
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 238 ± 2 ms. The average import time from base is: 245 ± 6 ms. The import time difference between this PR and base is: -7.1 ± 0.2 ms. Import time breakdownThe following import paths have shrunk:
|
Performance SLOsComparing candidate juanjux/retry-flares-cleanup (f68cb20) with baseline main (75241fe) 📈 Performance Regressions (1 suite)📈 iastaspects - 118/118✅ add_aspectTime: ✅ 0.407µs (SLO: <10.000µs 📉 -95.9%) vs baseline: -0.7% Memory: ✅ 37.316MB (SLO: <39.000MB -4.3%) vs baseline: +5.0% ✅ add_inplace_aspectTime: ✅ 0.412µs (SLO: <10.000µs 📉 -95.9%) vs baseline: +0.7% Memory: ✅ 37.277MB (SLO: <39.000MB -4.4%) vs baseline: +4.8% ✅ add_inplace_noaspectTime: ✅ 0.318µs (SLO: <10.000µs 📉 -96.8%) vs baseline: +0.6% Memory: ✅ 37.297MB (SLO: <39.000MB -4.4%) vs baseline: +4.9% ✅ add_noaspectTime: ✅ 0.277µs (SLO: <10.000µs 📉 -97.2%) vs baseline: -0.4% Memory: ✅ 37.238MB (SLO: <39.000MB -4.5%) vs baseline: +4.7% ✅ bytearray_aspectTime: ✅ 1.333µs (SLO: <10.000µs 📉 -86.7%) vs baseline: -0.3% Memory: ✅ 37.238MB (SLO: <39.000MB -4.5%) vs baseline: +4.7% ✅ bytearray_extend_aspectTime: ✅ 1.538µs (SLO: <10.000µs 📉 -84.6%) vs baseline: +0.9% Memory: ✅ 37.316MB (SLO: <39.000MB -4.3%) vs baseline: +4.9% ✅ bytearray_extend_noaspectTime: ✅ 0.614µs (SLO: <10.000µs 📉 -93.9%) vs baseline: ~same Memory: ✅ 37.257MB (SLO: <39.000MB -4.5%) vs baseline: +4.9% ✅ bytearray_noaspectTime: ✅ 0.482µs (SLO: <10.000µs 📉 -95.2%) vs baseline: +0.1% Memory: ✅ 37.218MB (SLO: <39.000MB -4.6%) vs baseline: +4.6% ✅ bytes_aspectTime: ✅ 1.291µs (SLO: <10.000µs 📉 -87.1%) vs baseline: +1.8% Memory: ✅ 37.218MB (SLO: <39.000MB -4.6%) vs baseline: +4.6% ✅ bytes_noaspectTime: ✅ 0.491µs (SLO: <10.000µs 📉 -95.1%) vs baseline: -1.1% Memory: ✅ 37.218MB (SLO: <39.000MB -4.6%) vs baseline: +4.6% ✅ bytesio_aspectTime: ✅ 1.313µs (SLO: <10.000µs 📉 -86.9%) vs baseline: -0.8% Memory: ✅ 37.336MB (SLO: <39.000MB -4.3%) vs baseline: +5.0% ✅ bytesio_noaspectTime: ✅ 0.492µs (SLO: <10.000µs 📉 -95.1%) vs baseline: -1.2% Memory: ✅ 37.277MB (SLO: <39.000MB -4.4%) vs baseline: +4.9% ✅ capitalize_aspectTime: ✅ 0.728µs (SLO: <10.000µs 📉 -92.7%) vs baseline: -0.8% Memory: ✅ 37.277MB (SLO: <39.000MB -4.4%) vs baseline: +4.9% ✅ capitalize_noaspectTime: ✅ 0.433µs (SLO: <10.000µs 📉 -95.7%) vs baseline: -0.3% Memory: ✅ 37.238MB (SLO: <39.000MB -4.5%) vs baseline: +4.8% ✅ casefold_aspectTime: ✅ 0.736µs (SLO: <10.000µs 📉 -92.6%) vs baseline: -0.7% Memory: ✅ 37.257MB (SLO: <39.000MB -4.5%) vs baseline: +4.9% ✅ casefold_noaspectTime: ✅ 0.373µs (SLO: <10.000µs 📉 -96.3%) vs baseline: +1.8% Memory: ✅ 37.277MB (SLO: <39.000MB -4.4%) vs baseline: +5.0% ✅ decode_aspectTime: ✅ 0.724µs (SLO: <10.000µs 📉 -92.8%) vs baseline: +0.1% Memory: ✅ 37.218MB (SLO: <39.000MB -4.6%) vs baseline: +4.6% ✅ decode_noaspectTime: ✅ 0.421µs (SLO: <10.000µs 📉 -95.8%) vs baseline: -0.3% Memory: ✅ 37.277MB (SLO: <39.000MB -4.4%) vs baseline: +4.9% ✅ encode_aspectTime: ✅ 0.707µs (SLO: <10.000µs 📉 -92.9%) vs baseline: -1.5% Memory: ✅ 37.297MB (SLO: <39.000MB -4.4%) vs baseline: +5.1% ✅ encode_noaspectTime: ✅ 0.402µs (SLO: <10.000µs 📉 -96.0%) vs baseline: +1.2% Memory: ✅ 37.257MB (SLO: <39.000MB -4.5%) vs baseline: +4.8% ✅ format_aspectTime: ✅ 3.299µs (SLO: <10.000µs 📉 -67.0%) vs baseline: -0.3% Memory: ✅ 37.257MB (SLO: <39.000MB -4.5%) vs baseline: +4.7% ✅ format_map_aspectTime: ✅ 3.498µs (SLO: <10.000µs 📉 -65.0%) vs baseline: ~same Memory: ✅ 37.238MB (SLO: <39.000MB -4.5%) vs baseline: +4.8% ✅ format_map_noaspectTime: ✅ 0.772µs (SLO: <10.000µs 📉 -92.3%) vs baseline: -0.2% Memory: ✅ 37.336MB (SLO: <39.000MB -4.3%) vs baseline: +5.0% ✅ format_noaspectTime: ✅ 0.594µs (SLO: <10.000µs 📉 -94.1%) vs baseline: +0.4% Memory: ✅ 37.238MB (SLO: <39.000MB -4.5%) vs baseline: +4.9% ✅ index_aspectTime: ✅ 0.360µs (SLO: <10.000µs 📉 -96.4%) vs baseline: +1.4% Memory: ✅ 37.297MB (SLO: <39.000MB -4.4%) vs baseline: +4.9% ✅ index_noaspectTime: ✅ 0.283µs (SLO: <10.000µs 📉 -97.2%) vs baseline: +1.4% Memory: ✅ 37.316MB (SLO: <39.000MB -4.3%) vs baseline: +4.9% ✅ join_aspectTime: ✅ 1.356µs (SLO: <10.000µs 📉 -86.4%) vs baseline: -0.4% Memory: ✅ 37.238MB (SLO: <39.000MB -4.5%) vs baseline: +4.9% ✅ join_noaspectTime: ✅ 0.493µs (SLO: <10.000µs 📉 -95.1%) vs baseline: ~same Memory: ✅ 37.297MB (SLO: <39.000MB -4.4%) vs baseline: +4.9% ✅ ljust_aspectTime: ✅ 2.539µs (SLO: <20.000µs 📉 -87.3%) vs baseline: -0.1% Memory: ✅ 37.316MB (SLO: <39.000MB -4.3%) vs baseline: +5.0% ✅ ljust_noaspectTime: ✅ 0.401µs (SLO: <10.000µs 📉 -96.0%) vs baseline: -0.8% Memory: ✅ 37.277MB (SLO: <39.000MB -4.4%) vs baseline: +4.9% ✅ lower_aspectTime: ✅ 2.220µs (SLO: <10.000µs 📉 -77.8%) vs baseline: +0.5% Memory: ✅ 37.316MB (SLO: <39.000MB -4.3%) vs baseline: +5.0% ✅ lower_noaspectTime: ✅ 0.364µs (SLO: <10.000µs 📉 -96.4%) vs baseline: -1.8% Memory: ✅ 37.316MB (SLO: <39.000MB -4.3%) vs baseline: +4.7% ✅ lstrip_aspectTime: ✅ 2.528µs (SLO: <20.000µs 📉 -87.4%) vs baseline: 📈 +13.3% Memory: ✅ 37.257MB (SLO: <39.000MB -4.5%) vs baseline: +4.7% ✅ lstrip_noaspectTime: ✅ 0.382µs (SLO: <10.000µs 📉 -96.2%) vs baseline: -2.1% Memory: ✅ 37.257MB (SLO: <39.000MB -4.5%) vs baseline: +4.8% ✅ modulo_aspectTime: ✅ 1.048µs (SLO: <10.000µs 📉 -89.5%) vs baseline: -0.4% Memory: ✅ 37.277MB (SLO: <39.000MB -4.4%) vs baseline: +4.8% ✅ modulo_aspect_for_bytearray_bytearrayTime: ✅ 1.585µs (SLO: <10.000µs 📉 -84.2%) vs baseline: +3.1% Memory: ✅ 37.257MB (SLO: <39.000MB -4.5%) vs baseline: +4.8% ✅ modulo_aspect_for_bytesTime: ✅ 0.973µs (SLO: <10.000µs 📉 -90.3%) vs baseline: -0.8% Memory: ✅ 37.277MB (SLO: <39.000MB -4.4%) vs baseline: +4.9% ✅ modulo_aspect_for_bytes_bytearrayTime: ✅ 1.237µs (SLO: <10.000µs 📉 -87.6%) vs baseline: -1.3% Memory: ✅ 37.316MB (SLO: <39.000MB -4.3%) vs baseline: +5.0% ✅ modulo_noaspectTime: ✅ 0.628µs (SLO: <10.000µs 📉 -93.7%) vs baseline: -0.5% Memory: ✅ 37.238MB (SLO: <39.000MB -4.5%) vs baseline: +4.7% ✅ replace_aspectTime: ✅ 4.870µs (SLO: <10.000µs 📉 -51.3%) vs baseline: +0.5% Memory: ✅ 37.316MB (SLO: <39.000MB -4.3%) vs baseline: +5.0% ✅ replace_noaspectTime: ✅ 0.462µs (SLO: <10.000µs 📉 -95.4%) vs baseline: +0.3% Memory: ✅ 37.238MB (SLO: <39.000MB -4.5%) vs baseline: +4.6% ✅ repr_aspectTime: ✅ 0.905µs (SLO: <10.000µs 📉 -90.9%) vs baseline: -0.8% Memory: ✅ 37.336MB (SLO: <39.000MB -4.3%) vs baseline: +5.1% ✅ repr_noaspectTime: ✅ 0.418µs (SLO: <10.000µs 📉 -95.8%) vs baseline: +0.2% Memory: ✅ 37.336MB (SLO: <39.000MB -4.3%) vs baseline: +4.9% ✅ rstrip_aspectTime: ✅ 1.883µs (SLO: <20.000µs 📉 -90.6%) vs baseline: -0.2% Memory: ✅ 37.277MB (SLO: <39.000MB -4.4%) vs baseline: +4.9% ✅ rstrip_noaspectTime: ✅ 0.376µs (SLO: <10.000µs 📉 -96.2%) vs baseline: -0.7% Memory: ✅ 37.316MB (SLO: <39.000MB -4.3%) vs baseline: +4.9% ✅ slice_aspectTime: ✅ 0.498µs (SLO: <10.000µs 📉 -95.0%) vs baseline: -1.0% Memory: ✅ 37.316MB (SLO: <39.000MB -4.3%) vs baseline: +4.9% ✅ slice_noaspectTime: ✅ 0.451µs (SLO: <10.000µs 📉 -95.5%) vs baseline: +0.8% Memory: ✅ 37.218MB (SLO: <39.000MB -4.6%) vs baseline: +4.6% ✅ stringio_aspectTime: ✅ 1.526µs (SLO: <10.000µs 📉 -84.7%) vs baseline: -1.8% Memory: ✅ 37.257MB (SLO: <39.000MB -4.5%) vs baseline: +5.0% ✅ stringio_noaspectTime: ✅ 0.724µs (SLO: <10.000µs 📉 -92.8%) vs baseline: -0.2% Memory: ✅ 37.277MB (SLO: <39.000MB -4.4%) vs baseline: +4.9% ✅ strip_aspectTime: ✅ 2.214µs (SLO: <20.000µs 📉 -88.9%) vs baseline: +0.2% Memory: ✅ 37.277MB (SLO: <39.000MB -4.4%) vs baseline: +4.9% ✅ strip_noaspectTime: ✅ 0.384µs (SLO: <10.000µs 📉 -96.2%) vs baseline: -2.4% Memory: ✅ 37.277MB (SLO: <39.000MB -4.4%) vs baseline: +4.7% ✅ swapcase_aspectTime: ✅ 2.400µs (SLO: <10.000µs 📉 -76.0%) vs baseline: -0.8% Memory: ✅ 37.336MB (SLO: <39.000MB -4.3%) vs baseline: +5.0% ✅ swapcase_noaspectTime: ✅ 0.533µs (SLO: <10.000µs 📉 -94.7%) vs baseline: -0.8% Memory: ✅ 37.297MB (SLO: <39.000MB -4.4%) vs baseline: +4.9% ✅ title_aspectTime: ✅ 2.327µs (SLO: <10.000µs 📉 -76.7%) vs baseline: -0.5% Memory: ✅ 37.218MB (SLO: <39.000MB -4.6%) vs baseline: +4.7% ✅ title_noaspectTime: ✅ 0.503µs (SLO: <10.000µs 📉 -95.0%) vs baseline: +0.5% Memory: ✅ 37.316MB (SLO: <39.000MB -4.3%) vs baseline: +4.9% ✅ translate_aspectTime: ✅ 3.376µs (SLO: <10.000µs 📉 -66.2%) vs baseline: +4.2% Memory: ✅ 37.297MB (SLO: <39.000MB -4.4%) vs baseline: +4.8% ✅ translate_noaspectTime: ✅ 1.034µs (SLO: <10.000µs 📉 -89.7%) vs baseline: -0.2% Memory: ✅ 37.257MB (SLO: <39.000MB -4.5%) vs baseline: +4.7% ✅ upper_aspectTime: ✅ 2.207µs (SLO: <10.000µs 📉 -77.9%) vs baseline: +0.3% Memory: ✅ 37.277MB (SLO: <39.000MB -4.4%) vs baseline: +4.7% ✅ upper_noaspectTime: ✅ 0.370µs (SLO: <10.000µs 📉 -96.3%) vs baseline: -0.5% Memory: ✅ 37.297MB (SLO: <39.000MB -4.4%) vs baseline: +4.9% 🟡 Near SLO Breach (5 suites)🟡 djangosimple - 30/30✅ appsecTime: ✅ 20.500ms (SLO: <22.300ms -8.1%) vs baseline: ~same Memory: ✅ 66.199MB (SLO: <67.000MB 🟡 -1.2%) vs baseline: +5.2% ✅ exception-replay-enabledTime: ✅ 1.340ms (SLO: <1.450ms -7.6%) vs baseline: +0.3% Memory: ✅ 64.131MB (SLO: <67.000MB -4.3%) vs baseline: +4.9% ✅ iastTime: ✅ 20.474ms (SLO: <22.250ms -8.0%) vs baseline: +0.2% Memory: ✅ 66.247MB (SLO: <67.000MB 🟡 -1.1%) vs baseline: +5.1% ✅ profilerTime: ✅ 15.570ms (SLO: <16.550ms -5.9%) vs baseline: +0.4% Memory: ✅ 53.985MB (SLO: <54.500MB 🟡 -0.9%) vs baseline: +4.9% ✅ resource-renamingTime: ✅ 20.521ms (SLO: <21.750ms -5.7%) vs baseline: -0.2% Memory: ✅ 66.100MB (SLO: <67.000MB 🟡 -1.3%) vs baseline: +4.9% ✅ span-code-originTime: ✅ 25.370ms (SLO: <28.200ms 📉 -10.0%) vs baseline: ~same Memory: ✅ 67.289MB (SLO: <69.500MB -3.2%) vs baseline: +3.6% ✅ tracerTime: ✅ 20.454ms (SLO: <21.750ms -6.0%) vs baseline: ~same Memory: ✅ 66.127MB (SLO: <67.000MB 🟡 -1.3%) vs baseline: +5.0% ✅ tracer-and-profilerTime: ✅ 22.809ms (SLO: <23.500ms -2.9%) vs baseline: +0.5% Memory: ✅ 67.837MB (SLO: <68.000MB 🟡 -0.2%) vs baseline: +4.8% ✅ tracer-dont-create-db-spansTime: ✅ 19.253ms (SLO: <21.500ms 📉 -10.5%) vs baseline: -0.4% Memory: ✅ 66.116MB (SLO: <67.000MB 🟡 -1.3%) vs baseline: +4.9% ✅ tracer-minimalTime: ✅ 16.629ms (SLO: <17.500ms -5.0%) vs baseline: -0.3% Memory: ✅ 66.100MB (SLO: <67.000MB 🟡 -1.3%) vs baseline: +4.9% ✅ tracer-nativeTime: ✅ 20.468ms (SLO: <21.750ms -5.9%) vs baseline: +0.2% Memory: ✅ 67.751MB (SLO: <72.500MB -6.6%) vs baseline: +4.8% ✅ tracer-no-cachesTime: ✅ 18.419ms (SLO: <19.650ms -6.3%) vs baseline: -0.4% Memory: ✅ 66.133MB (SLO: <67.000MB 🟡 -1.3%) vs baseline: +5.0% ✅ tracer-no-databasesTime: ✅ 18.805ms (SLO: <20.100ms -6.4%) vs baseline: +0.2% Memory: ✅ 65.835MB (SLO: <67.000MB 🟡 -1.7%) vs baseline: +4.6% ✅ tracer-no-middlewareTime: ✅ 20.212ms (SLO: <21.500ms -6.0%) vs baseline: ~same Memory: ✅ 66.138MB (SLO: <67.000MB 🟡 -1.3%) vs baseline: +5.0% ✅ tracer-no-templatesTime: ✅ 20.257ms (SLO: <22.000ms -7.9%) vs baseline: ~same Memory: ✅ 66.119MB (SLO: <67.000MB 🟡 -1.3%) vs baseline: +4.8% 🟡 errortrackingdjangosimple - 6/6✅ errortracking-enabled-allTime: ✅ 18.056ms (SLO: <19.850ms -9.0%) vs baseline: +0.2% Memory: ✅ 66.139MB (SLO: <66.500MB 🟡 -0.5%) vs baseline: +4.9% ✅ errortracking-enabled-userTime: ✅ 18.269ms (SLO: <19.400ms -5.8%) vs baseline: +1.2% Memory: ✅ 66.178MB (SLO: <66.500MB 🟡 -0.5%) vs baseline: +4.9% ✅ tracer-enabledTime: ✅ 18.058ms (SLO: <19.450ms -7.2%) vs baseline: -0.3% Memory: ✅ 65.854MB (SLO: <66.500MB 🟡 -1.0%) vs baseline: +4.9% 🟡 errortrackingflasksqli - 6/6✅ errortracking-enabled-allTime: ✅ 2.071ms (SLO: <2.300ms -10.0%) vs baseline: +0.3% Memory: ✅ 52.652MB (SLO: <53.500MB 🟡 -1.6%) vs baseline: +5.3% ✅ errortracking-enabled-userTime: ✅ 2.072ms (SLO: <2.250ms -7.9%) vs baseline: -0.2% Memory: ✅ 52.573MB (SLO: <53.500MB 🟡 -1.7%) vs baseline: +5.3% ✅ tracer-enabledTime: ✅ 2.075ms (SLO: <2.300ms -9.8%) vs baseline: +0.4% Memory: ✅ 52.593MB (SLO: <53.500MB 🟡 -1.7%) vs baseline: +5.2% 🟡 flasksimple - 18/18✅ appsec-getTime: ✅ 4.598ms (SLO: <4.750ms -3.2%) vs baseline: -0.3% Memory: ✅ 62.243MB (SLO: <65.000MB -4.2%) vs baseline: +4.6% ✅ appsec-postTime: ✅ 6.628ms (SLO: <6.750ms 🟡 -1.8%) vs baseline: ~same Memory: ✅ 62.381MB (SLO: <65.000MB -4.0%) vs baseline: +4.9% ✅ appsec-telemetryTime: ✅ 4.582ms (SLO: <4.750ms -3.5%) vs baseline: -0.5% Memory: ✅ 62.391MB (SLO: <65.000MB -4.0%) vs baseline: +4.9% ✅ debuggerTime: ✅ 1.851ms (SLO: <2.000ms -7.4%) vs baseline: -0.3% Memory: ✅ 45.228MB (SLO: <47.000MB -3.8%) vs baseline: +4.6% ✅ iast-getTime: ✅ 1.858ms (SLO: <2.000ms -7.1%) vs baseline: -0.5% Memory: ✅ 42.136MB (SLO: <49.000MB 📉 -14.0%) vs baseline: +4.9% ✅ profilerTime: ✅ 1.913ms (SLO: <2.100ms -8.9%) vs baseline: -0.2% Memory: ✅ 46.658MB (SLO: <47.000MB 🟡 -0.7%) vs baseline: +4.9% ✅ resource-renamingTime: ✅ 3.366ms (SLO: <3.650ms -7.8%) vs baseline: -0.2% Memory: ✅ 52.663MB (SLO: <53.500MB 🟡 -1.6%) vs baseline: +4.9% ✅ tracerTime: ✅ 3.349ms (SLO: <3.650ms -8.3%) vs baseline: ~same Memory: ✅ 52.608MB (SLO: <53.500MB 🟡 -1.7%) vs baseline: +4.7% ✅ tracer-nativeTime: ✅ 3.347ms (SLO: <3.650ms -8.3%) vs baseline: -0.2% Memory: ✅ 54.057MB (SLO: <60.000MB -9.9%) vs baseline: +4.8% 🟡 flasksqli - 6/6✅ appsec-enabledTime: ✅ 3.963ms (SLO: <4.200ms -5.7%) vs baseline: +0.2% Memory: ✅ 62.364MB (SLO: <66.000MB -5.5%) vs baseline: +4.8% ✅ iast-enabledTime: ✅ 2.445ms (SLO: <2.800ms 📉 -12.7%) vs baseline: +0.6% Memory: ✅ 58.904MB (SLO: <60.000MB 🟡 -1.8%) vs baseline: +4.8% ✅ tracer-enabledTime: ✅ 2.057ms (SLO: <2.250ms -8.6%) vs baseline: ~same Memory: ✅ 52.652MB (SLO: <54.500MB -3.4%) vs baseline: +4.8%
|
Description
Testing
Risks
Additional Notes