-
Notifications
You must be signed in to change notification settings - Fork 469
chore(di): add process_tags #15225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(di): add process_tags #15225
Conversation
|
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 257 ± 7 ms. The average import time from base is: 270 ± 5 ms. The import time difference between this PR and base is: -12.9 ± 0.3 ms. Import time breakdownThe following import paths have shrunk:
|
0795f26 to
e03aa8d
Compare
Performance SLOsComparing candidate dubloom/process-tags-dynamic-instrumentation (e176393) with baseline dubloom/process-tags-collection (efe28fa) 📈 Performance Regressions (1 suite)📈 iastaspects - 118/118✅ add_aspectTime: ✅ 0.405µs (SLO: <10.000µs 📉 -95.9%) vs baseline: +0.6% Memory: ✅ 39.813MB (SLO: <41.500MB -4.1%) vs baseline: +4.5% ✅ add_inplace_aspectTime: ✅ 0.407µs (SLO: <10.000µs 📉 -95.9%) vs baseline: ~same Memory: ✅ 39.892MB (SLO: <41.500MB -3.9%) vs baseline: +6.0% ✅ add_inplace_noaspectTime: ✅ 0.317µs (SLO: <10.000µs 📉 -96.8%) vs baseline: +0.2% Memory: ✅ 39.833MB (SLO: <41.500MB -4.0%) vs baseline: +4.8% ✅ add_noaspectTime: ✅ 0.277µs (SLO: <10.000µs 📉 -97.2%) vs baseline: +0.1% Memory: ✅ 39.852MB (SLO: <41.500MB -4.0%) vs baseline: +4.7% ✅ bytearray_aspectTime: ✅ 1.332µs (SLO: <10.000µs 📉 -86.7%) vs baseline: +1.4% Memory: ✅ 39.538MB (SLO: <41.500MB -4.7%) vs baseline: +4.8% ✅ bytearray_extend_aspectTime: ✅ 1.546µs (SLO: <10.000µs 📉 -84.5%) vs baseline: +3.0% Memory: ✅ 39.518MB (SLO: <41.500MB -4.8%) vs baseline: +4.6% ✅ bytearray_extend_noaspectTime: ✅ 0.617µs (SLO: <10.000µs 📉 -93.8%) vs baseline: -0.3% Memory: ✅ 39.499MB (SLO: <41.500MB -4.8%) vs baseline: +3.8% ✅ bytearray_noaspectTime: ✅ 0.485µs (SLO: <10.000µs 📉 -95.2%) vs baseline: -0.7% Memory: ✅ 39.951MB (SLO: <41.500MB -3.7%) vs baseline: +5.0% ✅ bytes_aspectTime: ✅ 1.279µs (SLO: <10.000µs 📉 -87.2%) vs baseline: -0.4% Memory: ✅ 39.754MB (SLO: <41.500MB -4.2%) vs baseline: +4.4% ✅ bytes_noaspectTime: ✅ 0.494µs (SLO: <10.000µs 📉 -95.1%) vs baseline: +0.2% Memory: ✅ 39.518MB (SLO: <41.500MB -4.8%) vs baseline: +3.8% ✅ bytesio_aspectTime: ✅ 1.299µs (SLO: <10.000µs 📉 -87.0%) vs baseline: ~same Memory: ✅ 39.518MB (SLO: <41.500MB -4.8%) vs baseline: +5.0% ✅ bytesio_noaspectTime: ✅ 0.496µs (SLO: <10.000µs 📉 -95.0%) vs baseline: -0.9% Memory: ✅ 39.518MB (SLO: <41.500MB -4.8%) vs baseline: +3.9% ✅ capitalize_aspectTime: ✅ 0.740µs (SLO: <10.000µs 📉 -92.6%) vs baseline: +0.3% Memory: ✅ 39.459MB (SLO: <41.500MB -4.9%) vs baseline: +3.7% ✅ capitalize_noaspectTime: ✅ 0.437µs (SLO: <10.000µs 📉 -95.6%) vs baseline: -0.7% Memory: ✅ 39.931MB (SLO: <41.500MB -3.8%) vs baseline: +4.8% ✅ casefold_aspectTime: ✅ 0.736µs (SLO: <10.000µs 📉 -92.6%) vs baseline: -1.5% Memory: ✅ 39.499MB (SLO: <41.500MB -4.8%) vs baseline: +5.0% ✅ casefold_noaspectTime: ✅ 0.368µs (SLO: <10.000µs 📉 -96.3%) vs baseline: -0.3% Memory: ✅ 39.479MB (SLO: <41.500MB -4.9%) vs baseline: +3.7% ✅ decode_aspectTime: ✅ 0.728µs (SLO: <10.000µs 📉 -92.7%) vs baseline: -0.5% Memory: ✅ 39.872MB (SLO: <41.500MB -3.9%) vs baseline: +5.6% ✅ decode_noaspectTime: ✅ 0.418µs (SLO: <10.000µs 📉 -95.8%) vs baseline: -0.2% Memory: ✅ 39.479MB (SLO: <41.500MB -4.9%) vs baseline: +3.9% ✅ encode_aspectTime: ✅ 0.709µs (SLO: <10.000µs 📉 -92.9%) vs baseline: -0.8% Memory: ✅ 39.833MB (SLO: <41.500MB -4.0%) vs baseline: +5.5% ✅ encode_noaspectTime: ✅ 0.401µs (SLO: <10.000µs 📉 -96.0%) vs baseline: -1.7% Memory: ✅ 39.499MB (SLO: <41.500MB -4.8%) vs baseline: +3.8% ✅ format_aspectTime: ✅ 3.392µs (SLO: <10.000µs 📉 -66.1%) vs baseline: +0.3% Memory: ✅ 39.833MB (SLO: <41.500MB -4.0%) vs baseline: +5.7% ✅ format_map_aspectTime: ✅ 3.559µs (SLO: <10.000µs 📉 -64.4%) vs baseline: -0.9% Memory: ✅ 39.833MB (SLO: <41.500MB -4.0%) vs baseline: +4.6% ✅ format_map_noaspectTime: ✅ 0.779µs (SLO: <10.000µs 📉 -92.2%) vs baseline: +0.4% Memory: ✅ 39.872MB (SLO: <41.500MB -3.9%) vs baseline: +4.8% ✅ format_noaspectTime: ✅ 0.594µs (SLO: <10.000µs 📉 -94.1%) vs baseline: ~same Memory: ✅ 39.518MB (SLO: <41.500MB -4.8%) vs baseline: +4.0% ✅ index_aspectTime: ✅ 0.358µs (SLO: <10.000µs 📉 -96.4%) vs baseline: -0.7% Memory: ✅ 39.734MB (SLO: <41.500MB -4.3%) vs baseline: +4.4% ✅ index_noaspectTime: ✅ 0.277µs (SLO: <10.000µs 📉 -97.2%) vs baseline: -1.1% Memory: ✅ 39.538MB (SLO: <41.500MB -4.7%) vs baseline: +3.8% ✅ join_aspectTime: ✅ 1.401µs (SLO: <10.000µs 📉 -86.0%) vs baseline: +1.6% Memory: ✅ 39.774MB (SLO: <41.500MB -4.2%) vs baseline: +5.0% ✅ join_noaspectTime: ✅ 0.488µs (SLO: <10.000µs 📉 -95.1%) vs baseline: -0.1% Memory: ✅ 39.951MB (SLO: <41.500MB -3.7%) vs baseline: +5.1% ✅ ljust_aspectTime: ✅ 2.512µs (SLO: <20.000µs 📉 -87.4%) vs baseline: -0.1% Memory: ✅ 39.931MB (SLO: <41.500MB -3.8%) vs baseline: +5.2% ✅ ljust_noaspectTime: ✅ 0.404µs (SLO: <10.000µs 📉 -96.0%) vs baseline: -0.3% Memory: ✅ 39.479MB (SLO: <41.500MB -4.9%) vs baseline: +3.8% ✅ lower_aspectTime: ✅ 2.214µs (SLO: <10.000µs 📉 -77.9%) vs baseline: +0.5% Memory: ✅ 39.852MB (SLO: <41.500MB -4.0%) vs baseline: +4.8% ✅ lower_noaspectTime: ✅ 0.373µs (SLO: <10.000µs 📉 -96.3%) vs baseline: +0.5% Memory: ✅ 39.440MB (SLO: <41.500MB -5.0%) vs baseline: +3.5% ✅ lstrip_aspectTime: ✅ 2.451µs (SLO: <20.000µs 📉 -87.7%) vs baseline: 📈 +11.1% Memory: ✅ 39.990MB (SLO: <41.500MB -3.6%) vs baseline: +6.1% ✅ lstrip_noaspectTime: ✅ 0.385µs (SLO: <10.000µs 📉 -96.1%) vs baseline: +0.8% Memory: ✅ 39.459MB (SLO: <41.500MB -4.9%) vs baseline: +3.7% ✅ modulo_aspectTime: ✅ 1.032µs (SLO: <10.000µs 📉 -89.7%) vs baseline: +2.7% Memory: ✅ 39.793MB (SLO: <41.500MB -4.1%) vs baseline: +5.3% ✅ modulo_aspect_for_bytearray_bytearrayTime: ✅ 1.556µs (SLO: <10.000µs 📉 -84.4%) vs baseline: +0.5% Memory: ✅ 39.793MB (SLO: <41.500MB -4.1%) vs baseline: +4.7% ✅ modulo_aspect_for_bytesTime: ✅ 1.020µs (SLO: <10.000µs 📉 -89.8%) vs baseline: +1.4% Memory: ✅ 39.538MB (SLO: <41.500MB -4.7%) vs baseline: +4.5% ✅ modulo_aspect_for_bytes_bytearrayTime: ✅ 1.259µs (SLO: <10.000µs 📉 -87.4%) vs baseline: +0.9% Memory: ✅ 39.400MB (SLO: <41.500MB -5.1%) vs baseline: +4.5% ✅ modulo_noaspectTime: ✅ 0.636µs (SLO: <10.000µs 📉 -93.6%) vs baseline: +1.0% Memory: ✅ 39.381MB (SLO: <41.500MB -5.1%) vs baseline: +3.5% ✅ replace_aspectTime: ✅ 4.884µs (SLO: <10.000µs 📉 -51.2%) vs baseline: +2.7% Memory: ✅ 39.872MB (SLO: <41.500MB -3.9%) vs baseline: +4.9% ✅ replace_noaspectTime: ✅ 0.463µs (SLO: <10.000µs 📉 -95.4%) vs baseline: -0.5% Memory: ✅ 39.459MB (SLO: <41.500MB -4.9%) vs baseline: +3.6% ✅ repr_aspectTime: ✅ 0.912µs (SLO: <10.000µs 📉 -90.9%) vs baseline: +0.9% Memory: ✅ 39.813MB (SLO: <41.500MB -4.1%) vs baseline: +4.6% ✅ repr_noaspectTime: ✅ 0.415µs (SLO: <10.000µs 📉 -95.9%) vs baseline: +0.2% Memory: ✅ 39.892MB (SLO: <41.500MB -3.9%) vs baseline: +5.1% ✅ rstrip_aspectTime: ✅ 1.882µs (SLO: <20.000µs 📉 -90.6%) vs baseline: +0.1% Memory: ✅ 39.892MB (SLO: <41.500MB -3.9%) vs baseline: +5.8% ✅ rstrip_noaspectTime: ✅ 0.382µs (SLO: <10.000µs 📉 -96.2%) vs baseline: ~same Memory: ✅ 39.459MB (SLO: <41.500MB -4.9%) vs baseline: +3.4% ✅ slice_aspectTime: ✅ 0.498µs (SLO: <10.000µs 📉 -95.0%) vs baseline: ~same Memory: ✅ 39.597MB (SLO: <41.500MB -4.6%) vs baseline: +4.1% ✅ slice_noaspectTime: ✅ 0.451µs (SLO: <10.000µs 📉 -95.5%) vs baseline: +0.2% Memory: ✅ 39.499MB (SLO: <41.500MB -4.8%) vs baseline: +3.8% ✅ stringio_aspectTime: ✅ 1.554µs (SLO: <10.000µs 📉 -84.5%) vs baseline: +0.5% Memory: ✅ 39.440MB (SLO: <41.500MB -5.0%) vs baseline: +3.8% ✅ stringio_noaspectTime: ✅ 0.720µs (SLO: <10.000µs 📉 -92.8%) vs baseline: -0.5% Memory: ✅ 39.459MB (SLO: <41.500MB -4.9%) vs baseline: +3.5% ✅ strip_aspectTime: ✅ 2.221µs (SLO: <20.000µs 📉 -88.9%) vs baseline: +1.6% Memory: ✅ 39.833MB (SLO: <41.500MB -4.0%) vs baseline: +4.6% ✅ strip_noaspectTime: ✅ 0.391µs (SLO: <10.000µs 📉 -96.1%) vs baseline: +2.3% Memory: ✅ 39.479MB (SLO: <41.500MB -4.9%) vs baseline: +3.8% ✅ swapcase_aspectTime: ✅ 2.401µs (SLO: <10.000µs 📉 -76.0%) vs baseline: +0.9% Memory: ✅ 39.931MB (SLO: <41.500MB -3.8%) vs baseline: +5.0% ✅ swapcase_noaspectTime: ✅ 0.540µs (SLO: <10.000µs 📉 -94.6%) vs baseline: +0.4% Memory: ✅ 39.341MB (SLO: <41.500MB -5.2%) vs baseline: +3.5% ✅ title_aspectTime: ✅ 2.350µs (SLO: <10.000µs 📉 -76.5%) vs baseline: +0.4% Memory: ✅ 39.892MB (SLO: <41.500MB -3.9%) vs baseline: +5.0% ✅ title_noaspectTime: ✅ 0.503µs (SLO: <10.000µs 📉 -95.0%) vs baseline: ~same Memory: ✅ 39.518MB (SLO: <41.500MB -4.8%) vs baseline: +3.7% ✅ translate_aspectTime: ✅ 3.178µs (SLO: <10.000µs 📉 -68.2%) vs baseline: -0.7% Memory: ✅ 39.852MB (SLO: <41.500MB -4.0%) vs baseline: +5.0% ✅ translate_noaspectTime: ✅ 1.047µs (SLO: <10.000µs 📉 -89.5%) vs baseline: -0.1% Memory: ✅ 39.911MB (SLO: <41.500MB -3.8%) vs baseline: +5.1% ✅ upper_aspectTime: ✅ 2.205µs (SLO: <10.000µs 📉 -78.0%) vs baseline: +0.5% Memory: ✅ 39.892MB (SLO: <41.500MB -3.9%) vs baseline: +4.6% ✅ upper_noaspectTime: ✅ 0.370µs (SLO: <10.000µs 📉 -96.3%) vs baseline: -0.2% Memory: ✅ 39.577MB (SLO: <41.500MB -4.6%) vs baseline: +4.0% 🟡 Near SLO Breach (1 suite)🟡 otelspan - 22/22✅ add-eventTime: ✅ 38.643ms (SLO: <47.150ms 📉 -18.0%) vs baseline: ~same Memory: ✅ 39.114MB (SLO: <47.000MB 📉 -16.8%) vs baseline: +4.9% ✅ add-metricsTime: ✅ 259.354ms (SLO: <344.800ms 📉 -24.8%) vs baseline: +0.3% Memory: ✅ 43.275MB (SLO: <47.500MB -8.9%) vs baseline: +4.8% ✅ add-tagsTime: ✅ 315.439ms (SLO: <321.000ms 🟡 -1.7%) vs baseline: +0.4% Memory: ✅ 43.315MB (SLO: <47.500MB -8.8%) vs baseline: +5.0% ✅ get-contextTime: ✅ 79.345ms (SLO: <92.350ms 📉 -14.1%) vs baseline: +0.9% Memory: ✅ 39.200MB (SLO: <46.500MB 📉 -15.7%) vs baseline: +4.5% ✅ is-recordingTime: ✅ 36.990ms (SLO: <44.500ms 📉 -16.9%) vs baseline: +2.2% Memory: ✅ 38.862MB (SLO: <47.500MB 📉 -18.2%) vs baseline: +5.0% ✅ record-exceptionTime: ✅ 56.951ms (SLO: <67.650ms 📉 -15.8%) vs baseline: ~same Memory: ✅ 39.348MB (SLO: <47.000MB 📉 -16.3%) vs baseline: +4.4% ✅ set-statusTime: ✅ 42.681ms (SLO: <50.400ms 📉 -15.3%) vs baseline: +0.7% Memory: ✅ 38.925MB (SLO: <47.000MB 📉 -17.2%) vs baseline: +5.0% ✅ startTime: ✅ 35.439ms (SLO: <43.450ms 📉 -18.4%) vs baseline: +0.1% Memory: ✅ 38.847MB (SLO: <47.000MB 📉 -17.3%) vs baseline: +5.0% ✅ start-finishTime: ✅ 83.304ms (SLO: <88.000ms -5.3%) vs baseline: +1.4% Memory: ✅ 36.589MB (SLO: <46.500MB 📉 -21.3%) vs baseline: +4.7% ✅ start-finish-telemetryTime: ✅ 83.610ms (SLO: <89.000ms -6.1%) vs baseline: -0.2% Memory: ✅ 36.549MB (SLO: <46.500MB 📉 -21.4%) vs baseline: +5.0% ✅ update-nameTime: ✅ 36.931ms (SLO: <45.150ms 📉 -18.2%) vs baseline: -0.2% Memory: ✅ 38.994MB (SLO: <47.000MB 📉 -17.0%) vs baseline: +4.9%
|
2b05ee8 to
e176393
Compare
fdd6480
into
dubloom/process-tags-collection
This PR implements this RFC for dynamic instrumentation.
Add process_tags to dynamic instrumentation payload
Testing