-
Notifications
You must be signed in to change notification settings - Fork 469
chore(profiling): upgrade echion #15311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
d7cd8c7 to
524ebac
Compare
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 251 ± 3 ms. The average import time from base is: 260 ± 10 ms. The import time difference between this PR and base is: -10.4 ± 0.5 ms. Import time breakdownThe following import paths have shrunk:
|
Performance SLOsComparing candidate kowalski/chore-profiling-upgrade-echion (3a560c3) with baseline main (30d88d9) 📈 Performance Regressions (1 suite)📈 telemetryaddmetric - 30/30✅ 1-count-metric-1-timesTime: ✅ 3.316µs (SLO: <20.000µs 📉 -83.4%) vs baseline: 📈 +10.4% Memory: ✅ 34.524MB (SLO: <35.500MB -2.7%) vs baseline: +4.9% ✅ 1-count-metrics-100-timesTime: ✅ 202.089µs (SLO: <220.000µs -8.1%) vs baseline: -0.7% Memory: ✅ 34.603MB (SLO: <35.500MB -2.5%) vs baseline: +5.2% ✅ 1-distribution-metric-1-timesTime: ✅ 3.627µs (SLO: <20.000µs 📉 -81.9%) vs baseline: +7.0% Memory: ✅ 34.583MB (SLO: <35.500MB -2.6%) vs baseline: +5.2% ✅ 1-distribution-metrics-100-timesTime: ✅ 219.424µs (SLO: <220.000µs 🟡 -0.3%) vs baseline: -0.5% Memory: ✅ 34.524MB (SLO: <35.500MB -2.7%) vs baseline: +4.8% ✅ 1-gauge-metric-1-timesTime: ✅ 2.167µs (SLO: <20.000µs 📉 -89.2%) vs baseline: -1.7% Memory: ✅ 34.544MB (SLO: <35.500MB -2.7%) vs baseline: +5.1% ✅ 1-gauge-metrics-100-timesTime: ✅ 137.044µs (SLO: <150.000µs -8.6%) vs baseline: ~same Memory: ✅ 34.564MB (SLO: <35.500MB -2.6%) vs baseline: +5.0% ✅ 1-rate-metric-1-timesTime: ✅ 3.478µs (SLO: <20.000µs 📉 -82.6%) vs baseline: 📈 +11.5% Memory: ✅ 34.524MB (SLO: <35.500MB -2.7%) vs baseline: +4.7% ✅ 1-rate-metrics-100-timesTime: ✅ 215.760µs (SLO: <250.000µs 📉 -13.7%) vs baseline: -0.4% Memory: ✅ 34.564MB (SLO: <35.500MB -2.6%) vs baseline: +4.9% ✅ 100-count-metrics-100-timesTime: ✅ 20.255ms (SLO: <22.000ms -7.9%) vs baseline: +2.5% Memory: ✅ 34.465MB (SLO: <35.500MB -2.9%) vs baseline: +4.7% ✅ 100-distribution-metrics-100-timesTime: ✅ 2.250ms (SLO: <2.300ms -2.2%) vs baseline: -0.4% Memory: ✅ 34.583MB (SLO: <35.500MB -2.6%) vs baseline: +4.9% ✅ 100-gauge-metrics-100-timesTime: ✅ 1.406ms (SLO: <1.550ms -9.3%) vs baseline: -0.3% Memory: ✅ 34.524MB (SLO: <35.500MB -2.7%) vs baseline: +5.0% ✅ 100-rate-metrics-100-timesTime: ✅ 2.195ms (SLO: <2.550ms 📉 -13.9%) vs baseline: +0.6% Memory: ✅ 34.465MB (SLO: <35.500MB -2.9%) vs baseline: +4.7% ✅ flush-1-metricTime: ✅ 4.915µs (SLO: <20.000µs 📉 -75.4%) vs baseline: +5.1% Memory: ✅ 34.544MB (SLO: <35.500MB -2.7%) vs baseline: +5.0% ✅ flush-100-metricsTime: ✅ 175.609µs (SLO: <250.000µs 📉 -29.8%) vs baseline: +0.2% Memory: ✅ 34.465MB (SLO: <35.500MB -2.9%) vs baseline: +4.9% ✅ flush-1000-metricsTime: ✅ 2.125ms (SLO: <2.500ms 📉 -15.0%) vs baseline: ~same Memory: ✅ 35.271MB (SLO: <36.500MB -3.4%) vs baseline: +4.8% 🟡 Near SLO Breach (2 suites)🟡 flasksimple - 18/18✅ appsec-getTime: ✅ 4.591ms (SLO: <4.750ms -3.4%) vs baseline: -0.2% Memory: ✅ 63.945MB (SLO: <66.500MB -3.8%) vs baseline: +4.8% ✅ appsec-postTime: ✅ 6.620ms (SLO: <6.750ms 🟡 -1.9%) vs baseline: ~same Memory: ✅ 64.358MB (SLO: <66.500MB -3.2%) vs baseline: +5.0% ✅ appsec-telemetryTime: ✅ 4.577ms (SLO: <4.750ms -3.6%) vs baseline: -0.4% Memory: ✅ 64.028MB (SLO: <66.500MB -3.7%) vs baseline: +4.9% ✅ debuggerTime: ✅ 1.853ms (SLO: <2.000ms -7.4%) vs baseline: ~same Memory: ✅ 47.945MB (SLO: <49.500MB -3.1%) vs baseline: +5.0% ✅ iast-getTime: ✅ 1.854ms (SLO: <2.000ms -7.3%) vs baseline: -0.3% Memory: ✅ 44.424MB (SLO: <49.000MB -9.3%) vs baseline: +4.8% ✅ profilerTime: ✅ 1.926ms (SLO: <2.100ms -8.3%) vs baseline: ~same Memory: ✅ 48.326MB (SLO: <50.000MB -3.3%) vs baseline: +4.6% ✅ resource-renamingTime: ✅ 3.366ms (SLO: <3.650ms -7.8%) vs baseline: -0.3% Memory: ✅ 54.732MB (SLO: <56.000MB -2.3%) vs baseline: +5.8% ✅ tracerTime: ✅ 3.357ms (SLO: <3.650ms -8.0%) vs baseline: ~same Memory: ✅ 54.337MB (SLO: <56.500MB -3.8%) vs baseline: +4.7% ✅ tracer-nativeTime: ✅ 3.358ms (SLO: <3.650ms -8.0%) vs baseline: -0.2% Memory: ✅ 54.690MB (SLO: <60.000MB -8.8%) vs baseline: +5.4% 🟡 otelspan - 22/22✅ add-eventTime: ✅ 38.641ms (SLO: <47.150ms 📉 -18.0%) vs baseline: +0.8% Memory: ✅ 38.942MB (SLO: <47.000MB 📉 -17.1%) vs baseline: +4.5% ✅ add-metricsTime: ✅ 256.424ms (SLO: <344.800ms 📉 -25.6%) vs baseline: -0.4% Memory: ✅ 43.293MB (SLO: <47.500MB -8.9%) vs baseline: +5.0% ✅ add-tagsTime: ✅ 315.430ms (SLO: <321.000ms 🟡 -1.7%) vs baseline: +1.1% Memory: ✅ 43.239MB (SLO: <47.500MB -9.0%) vs baseline: +4.6% ✅ get-contextTime: ✅ 78.662ms (SLO: <92.350ms 📉 -14.8%) vs baseline: +0.2% Memory: ✅ 39.278MB (SLO: <46.500MB 📉 -15.5%) vs baseline: +5.0% ✅ is-recordingTime: ✅ 36.109ms (SLO: <44.500ms 📉 -18.9%) vs baseline: +0.5% Memory: ✅ 38.791MB (SLO: <47.500MB 📉 -18.3%) vs baseline: +4.6% ✅ record-exceptionTime: ✅ 56.965ms (SLO: <67.650ms 📉 -15.8%) vs baseline: +0.1% Memory: ✅ 39.371MB (SLO: <47.000MB 📉 -16.2%) vs baseline: +4.7% ✅ set-statusTime: ✅ 42.330ms (SLO: <50.400ms 📉 -16.0%) vs baseline: -0.2% Memory: ✅ 38.780MB (SLO: <47.000MB 📉 -17.5%) vs baseline: +4.5% ✅ startTime: ✅ 35.325ms (SLO: <43.450ms 📉 -18.7%) vs baseline: +0.6% Memory: ✅ 38.806MB (SLO: <47.000MB 📉 -17.4%) vs baseline: +4.9% ✅ start-finishTime: ✅ 82.039ms (SLO: <88.000ms -6.8%) vs baseline: +0.2% Memory: ✅ 36.510MB (SLO: <46.500MB 📉 -21.5%) vs baseline: +4.6% ✅ start-finish-telemetryTime: ✅ 83.459ms (SLO: <89.000ms -6.2%) vs baseline: -0.2% Memory: ✅ 36.569MB (SLO: <46.500MB 📉 -21.4%) vs baseline: +4.6% ✅ update-nameTime: ✅ 36.882ms (SLO: <45.150ms 📉 -18.3%) vs baseline: -0.8% Memory: ✅ 38.972MB (SLO: <47.000MB 📉 -17.1%) vs baseline: +5.3%
|
524ebac to
83f1485
Compare
|
Note @taegyunkim I had forgotten to do it but I also had to port the patch for Just pushed the change and added a test. |
cc634a8 to
c38ab5d
Compare
a1803ed to
79fb5a2
Compare
Description
This upgrades Echion to the latest version.
There were quite a lot of commits but mostly just tests being added.
Changes
Relevant PRs:
asyncio.waitP403n1x87/echion#188Other PRs:
asyncio.waitP403n1x87/echion#185asyncio.as_completedP403n1x87/echion#186