-
Notifications
You must be signed in to change notification settings - Fork 469
chore(dsm): add process tags to dsm #15356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ags-remote-config
|
|
Bootstrap import analysisComparison of import times between this PR and base. SummaryThe average import time from this PR is: 256 ± 8 ms. The average import time from base is: 268 ± 7 ms. The import time difference between this PR and base is: -11.9 ± 0.3 ms. Import time breakdownThe following import paths have shrunk:
|
Performance SLOsComparing candidate dubloom/process-tags-dsm (c012b48) with baseline main (33c52d1) 📈 Performance Regressions (1 suite)📈 telemetryaddmetric - 30/30✅ 1-count-metric-1-timesTime: ✅ 3.094µs (SLO: <20.000µs 📉 -84.5%) vs baseline: +7.1% Memory: ✅ 34.603MB (SLO: <35.500MB -2.5%) vs baseline: +4.9% ✅ 1-count-metrics-100-timesTime: ✅ 200.560µs (SLO: <220.000µs -8.8%) vs baseline: ~same Memory: ✅ 34.603MB (SLO: <35.500MB -2.5%) vs baseline: +4.9% ✅ 1-distribution-metric-1-timesTime: ✅ 3.262µs (SLO: <20.000µs 📉 -83.7%) vs baseline: +0.3% Memory: ✅ 34.623MB (SLO: <35.500MB -2.5%) vs baseline: +4.8% ✅ 1-distribution-metrics-100-timesTime: ✅ 214.400µs (SLO: <230.000µs -6.8%) vs baseline: +0.1% Memory: ✅ 34.642MB (SLO: <35.500MB -2.4%) vs baseline: +5.0% ✅ 1-gauge-metric-1-timesTime: ✅ 2.538µs (SLO: <20.000µs 📉 -87.3%) vs baseline: 📈 +17.0% Memory: ✅ 34.623MB (SLO: <35.500MB -2.5%) vs baseline: +4.9% ✅ 1-gauge-metrics-100-timesTime: ✅ 136.804µs (SLO: <150.000µs -8.8%) vs baseline: +0.2% Memory: ✅ 34.564MB (SLO: <35.500MB -2.6%) vs baseline: +4.7% ✅ 1-rate-metric-1-timesTime: ✅ 3.057µs (SLO: <20.000µs 📉 -84.7%) vs baseline: +0.1% Memory: ✅ 34.662MB (SLO: <35.500MB -2.4%) vs baseline: +5.1% ✅ 1-rate-metrics-100-timesTime: ✅ 214.382µs (SLO: <250.000µs 📉 -14.2%) vs baseline: -0.3% Memory: ✅ 34.682MB (SLO: <35.500MB -2.3%) vs baseline: +5.1% ✅ 100-count-metrics-100-timesTime: ✅ 20.446ms (SLO: <22.000ms -7.1%) vs baseline: +0.3% Memory: ✅ 34.603MB (SLO: <35.500MB -2.5%) vs baseline: +4.9% ✅ 100-distribution-metrics-100-timesTime: ✅ 2.287ms (SLO: <2.300ms 🟡 -0.6%) vs baseline: +1.1% Memory: ✅ 34.544MB (SLO: <35.500MB -2.7%) vs baseline: +4.4% ✅ 100-gauge-metrics-100-timesTime: ✅ 1.414ms (SLO: <1.550ms -8.8%) vs baseline: +0.9% Memory: ✅ 34.564MB (SLO: <35.500MB -2.6%) vs baseline: +4.5% ✅ 100-rate-metrics-100-timesTime: ✅ 2.199ms (SLO: <2.550ms 📉 -13.8%) vs baseline: -0.9% Memory: ✅ 34.662MB (SLO: <35.500MB -2.4%) vs baseline: +5.0% ✅ flush-1-metricTime: ✅ 4.708µs (SLO: <20.000µs 📉 -76.5%) vs baseline: +6.5% Memory: ✅ 34.603MB (SLO: <35.500MB -2.5%) vs baseline: +4.7% ✅ flush-100-metricsTime: ✅ 172.757µs (SLO: <250.000µs 📉 -30.9%) vs baseline: -0.6% Memory: ✅ 34.642MB (SLO: <35.500MB -2.4%) vs baseline: +4.9% ✅ flush-1000-metricsTime: ✅ 2.129ms (SLO: <2.500ms 📉 -14.8%) vs baseline: +0.6% Memory: ✅ 35.330MB (SLO: <36.500MB -3.2%) vs baseline: +4.6%
|
emmettbutler
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think this needs a release note? I'm unsure.
|
@emmettbutler Thanks for approving, for the release note, we discussed it with Wan and Brett and we did not put any for the rest of the products |
This PR implements this RFC for DSM.
Add process_tags to DSM payload tags
Testing