falcon: fix missing import in docs #155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

clutchski merged 1 commit into master from matt/falcon

Jan 25, 2017

Contributor

clutchski commented Jan 25, 2017

No description provided.


          falcon: fix missing import in docs

073123a

LotharSee approved these changes

View reviewed changes

clutchski merged commit 7d5111a into master

clutchski deleted the matt/falcon branch

January 25, 2017 22:32

taegyunkim added a commit that referenced this pull request


          fix(core): use unpatched lock from forksafe module (#15151)

75241fe

## Description

<!-- Provide an overview of the change and motivation for the change -->
From a recent profiling escalation, we've seen a flamegraph where
forksafe lock is calling into patched profiling lock.
<img width="918" height="329" alt=" "
src="https://github.com/user-attachments/assets/3bff0b94-4ad7-49b1-847f-61812e2f43eb"
/>

The library used in above flamegraph is version 3.17.0.

From the leaf frame
1. [_release
(_lock.py:#155)](https://github.com/DataDog/dd-trace-py/blob/7451e8468236787abefb164407a8bd75dd005501/ddtrace/profiling/collector/_lock.py#L155)
2. [\_\_exit__
(_lock.py:L#206)](https://github.com/DataDog/dd-trace-py/blob/7451e8468236787abefb164407a8bd75dd005501/ddtrace/profiling/collector/_lock.py#L206)
3. [start
(service.py:L#57)](https://github.com/DataDog/dd-trace-py/blob/7451e8468236787abefb164407a8bd75dd005501/ddtrace/internal/service.py#L57)


https://github.com/DataDog/dd-trace-py/blob/7451e8468236787abefb164407a8bd75dd005501/ddtrace/internal/service.py#L57-L61

`self._service_lock` is declared as a `forksafe.Lock()` 


https://github.com/DataDog/dd-trace-py/blob/7451e8468236787abefb164407a8bd75dd005501/ddtrace/internal/service.py#L33

## Testing

<!-- Describe your testing strategy or note what tests are included -->

## Risks

<!-- Note any risks associated with this change, or "None" if no risks
-->

## Additional Notes

<!-- Any other information that would be helpful for reviewers -->

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet