removing ddtrace.ext.http.normalize_status_code #2595
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brettlangdon
changed the title
brettlangdon
added
the
changelog/no-changelog
P403n1x87
previously approved these changes
Jun 29, 2021
Contributor
P403n1x87
left a comment
P403n1x87
left a comment
There was a problem hiding this comment.
Nice find! Just a comment, otherwise LGTM. Feel free to ignore.
ddtrace/contrib/falcon/middleware.py
Outdated
| return # unexpected | ||
|
|
||
| status = httpx.normalize_status_code(resp.status) | ||
| status = resp.status.split(" ")[0] |
Contributor
There was a problem hiding this comment.
If we only want a single split we could either use partition or set the maxsplit argument to 1. I'd do something like:
status = resp.status.partition(" ")[0]This will prevent scanning the string for further splitting points, but would still create 3 strings. Perhaps searching for the first space and returning a slice would be the most efficient approach.
Yun-Kim
approved these changes
Jun 29, 2021
brettlangdon
approved these changes
Jun 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This updates two files. This first file /dd-trace-py/ddtrace/ext/http.py is to remove the function [normalize_status_code]. The second is to update where the function was used, ddtrace/contrib/falcon/middleware.py.
Checklist