fix(internal) cdef Python exceptions being ignored (backport #3008) #3014
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix(internal) cdef Python exceptions being ignored In a cdef function `raise` statements will create a Python exception, add it to the exception stack, and then immediately return. However, the caller will not explicitly check to see if any exception has occurred unless an exception return value has been provided. Until now these cdef functions when they encountered a `raise` would push the Python exception, and then return the default `int` value of `0`. Which based on how we use the return values `0` means success. This means that anytime we encounter an exception in our encoder we potentially ignore any exceptions and still append the partially encoded trace into the buffer. With this change we are standardizing around `except? -1` which tells the caller that their _might_ be a Python exception if the return value is `-1`. We do this because the `msgpack_*` functions we call will also return `-1` on error, but will not create a Python exception. * add release note * Update integration tests * remove unused import * set file encoding * Update releasenotes/notes/fix-encoding-exceptions-c12900b38741d2bf.yaml Co-authored-by: Tahir H. Butt <tahir.butt@datadoghq.com> Co-authored-by: Tahir H. Butt <tahir.butt@datadoghq.com> (cherry picked from commit 1b6cec4)
brettlangdon
approved these changes
Nov 15, 2021
Kyle-Verhoog
approved these changes
Nov 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automatic backport of pull request #3008 done by Mergify.
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refreshwill re-evaluate the rules@Mergifyio rebasewill rebase this PR on its base branch@Mergifyio updatewill merge the base branch into this PR@Mergifyio backport <destination>will backport this PR on<destination>branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.com