Skip to content

Conversation

@palazzem
Copy link

Overview

Some versions of aiohttp may use yarl>=1.0 that drops some methods. In that case it's not possible to run tests for aiohttp because of:

  File "/root/project/.tox/py34-aiohttp12-aiohttp_jinja012/lib/python3.4/site-packages/aiohttp/web_urldispatcher.py", line 14, in <module>
    from yarl import URL, quote, unquote
ImportError: cannot import name 'quote'

Pinning yarl to version 0.18 fixes the problem.

@palazzem palazzem added this to the 0.10.1 milestone Jan 24, 2018
@gabsn
Copy link

gabsn commented Jan 24, 2018

+1

vinvol
vinvol previously approved these changes Jan 24, 2018
@palazzem palazzem force-pushed the palazzem/aiohttp-testsuite branch 2 times, most recently from 5775d77 to 0c4a1ce Compare January 24, 2018 19:57
@palazzem palazzem force-pushed the palazzem/aiohttp-testsuite branch from 0c4a1ce to 1178bce Compare January 24, 2018 21:14
Copy link

@delner delner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@palazzem palazzem merged commit 71f2e6d into master Jan 24, 2018
@palazzem palazzem deleted the palazzem/aiohttp-testsuite branch January 24, 2018 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants