Skip to content

chore(debugging): fix exploration debugger import #4180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 9, 2022
Merged

chore(debugging): fix exploration debugger import #4180

merged 1 commit into from
Sep 9, 2022

Conversation

@P403n1x87
Copy link
Contributor

@P403n1x87 P403n1x87 commented Sep 9, 2022 •
edited
Loading

Description

With the recent refactor that enabled RCM for the debugger, the content of the old probe poller module has been moved in the probe remoteconfig one. This change fixes an import that was still referecing the removed module and prevented the exploration debuggers from running.

A test has also been added to catch potential issues with the exploration debuggers in the future.

Checklist

Reviewer Checklist

  • Title is accurate.
  • Description motivates each change.
  • No unnecessary changes were introduced in this PR.
  • PR cannot be broken up into smaller PRs.
  • Avoid breaking API changes unless absolutely necessary.
  • Tests provided or description of manual testing performed is included in the code or PR.
  • Release note has been added for fixes and features, or else changelog/no-changelog label added.
  • All relevant GitHub issues are correctly linked.
  • Backports are identified and tagged with Mergifyio.
  • Add to milestone.

@P403n1x87 P403n1x87 added the changelog/no-changelog A changelog entry is not required for this PR. label Sep 9, 2022
@P403n1x87 P403n1x87 requested a review from a team as a code owner September 9, 2022 14:12
@P403n1x87
chore(debugging): fix exploration debugger import
7021c96 
With the recent refactor that enabled RCM for the debugger, the content
of the old probe poller module has been moved in the probe remoteconfig
one. This change fixes an import that was still referecing the removed
module and prevented the exploration debuggers from running.

A test has also been added to catch potential issues with the
exploration debuggers in the future.
@P403n1x87 P403n1x87 force-pushed the chore/debugger-exploration-import-fix branch from 9067d87 to 7021c96 Compare September 9, 2022 14:17
cimi
cimi approved these changes Sep 9, 2022
View reviewed changes
Copy link

@cimi cimi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mergify mergify bot merged commit fde91fd into DataDog:1.x Sep 9, 2022
@P403n1x87 P403n1x87 deleted the chore/debugger-exploration-import-fix branch September 12, 2022 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@majorgreys majorgreys majorgreys approved these changes

@Kyle-Verhoog Kyle-Verhoog Kyle-Verhoog approved these changes

+1 more reviewer

@cimi cimi cimi approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

changelog/no-changelog A changelog entry is not required for this PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@P403n1x87 @majorgreys @cimi @Kyle-Verhoog