fix: remove url parts from http.url tag [backport #4904 to 1.6] #4906
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fix removes unintended url parts in the `http.url` tag. Co-authored-by: Brett Langdon <brett.langdon@datadoghq.com>
brettlangdon
previously approved these changes
Jan 14, 2023
mabdinur
previously approved these changes
Jan 14, 2023
tests/snapshots/tests.contrib.aiohttp.test_aiohttp_client.test_auth_200_request.json
Outdated
Show resolved
Hide resolved
…_auth_200_request.json
brettlangdon
previously approved these changes
Jan 14, 2023
tests/snapshots/tests.contrib.aiohttp.test_aiohttp_client.test_auth_200_request.json
Outdated
Show resolved
Hide resolved
…_auth_200_request.json
tests/snapshots/tests.contrib.aiohttp.test_aiohttp_client.test_auth_200_request.json
Outdated
Show resolved
Hide resolved
tests/snapshots/tests.contrib.aiohttp.test_aiohttp_client.test_auth_200_request.json
Outdated
Show resolved
Hide resolved
tests/snapshots/tests.contrib.aiohttp.test_aiohttp_client.test_auth_200_request.json
Outdated
Show resolved
Hide resolved
tests/snapshots/tests.contrib.aiohttp.test_aiohttp_client.test_auth_200_request.json
Outdated
Show resolved
Hide resolved
tests/snapshots/tests.contrib.aiohttp.test_aiohttp_client.test_auth_200_request.json
Outdated
Show resolved
Hide resolved
…_auth_200_request.json
majorgreys
approved these changes
Jan 14, 2023
Codecov Report
@@ Coverage Diff @@
## 1.6 #4906 +/- ##
=======================================
Coverage 78.21% 78.21%
=======================================
Files 757 757
Lines 60228 60263 +35
=======================================
+ Hits 47106 47136 +30
- Misses 13122 13127 +5
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
brettlangdon
added a commit
that referenced
this pull request
Jan 14, 2023
This fix removes unintended url parts in the `http.url` tag. Co-authored-by: Brett Langdon <brett.langdon@datadoghq.com> <!-- Briefly describe the change and why it was required. --> <!-- If this is a breaking change, explain why it is necessary. Breaking changes must append `!` after the type/scope. See https://ddtrace.readthedocs.io/en/stable/contributing.html for more details. --> - [x] Followed the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/contributing.html#Release-Note-Guidelines) when writing a release note. - [x] Add additional sections for `feat` and `fix` pull requests. - [x] [Library documentation](https://github.com/DataDog/dd-trace-py/tree/1.x/docs) and/or [Datadog's documentation site](https://github.com/DataDog/documentation/) is updated. Link to doc PR in description. <!-- Copy and paste the relevant snippet based on the type of pull request --> <!-- START feat --> <!-- Expand on why the change is required, include relevant context for reviewers --> <!-- Include benefits from the change as well as possible drawbacks and trade-offs --> <!-- Describe the automated tests and/or the steps for manual testing. <!-- END feat --> <!-- START fix --> <!-- Link the pull request to any issues related to the fix. Use keywords for links to automate closing the issues once the pull request is merged. --> <!-- Describe any added regression tests and/or the manual testing performed. --> <!-- END fix --> - [ ] Title is accurate. - [ ] Description motivates each change. - [ ] No unnecessary changes were introduced in this PR. - [ ] Avoid breaking [API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces) changes unless absolutely necessary. - [ ] Tests provided or description of manual testing performed is included in the code or PR. - [ ] Release note has been added and follows the [library release note guidelines](https://ddtrace.readthedocs.io/en/stable/contributing.html#Release-Note-Guidelines), or else `changelog/no-changelog` label added. - [ ] All relevant GitHub issues are correctly linked. - [ ] Backports are identified and tagged with Mergifyio. Co-authored-by: Tahir H. Butt <tahir.butt@datadoghq.com> Co-authored-by: Brett Langdon <brett.langdon@datadoghq.com>
brettlangdon
added a commit
that referenced
this pull request
Jan 14, 2023
Backport of #4906 This fix removes unintended url parts in the `http.url` tag. Co-authored-by: Tahir H. Butt <tahir.butt@datadoghq.com> Co-authored-by: Brett Langdon <brett.langdon@datadoghq.com> Co-authored-by: Zachary Groves <32471391+ZStriker19@users.noreply.github.com> Co-authored-by: Tahir H. Butt <tahir.butt@datadoghq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix removes unintended url parts in the
http.urltag.Co-authored-by: Brett Langdon brett.langdon@datadoghq.com
Description
Checklist
featandfixpull requests.Motivation
Design
Testing strategy
Relevant issue(s)
Testing strategy
Reviewer Checklist
changelog/no-changeloglabel added.