-
Notifications
You must be signed in to change notification settings - Fork 468
fix(rcm): store payloads target files content #5270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gnufede
previously approved these changes
Mar 6, 2023
christophe-papazian
previously approved these changes
Mar 6, 2023
juanjux
previously approved these changes
Mar 6, 2023
cae9f57
gnufede
previously approved these changes
Mar 6, 2023
Codecov Report
@@ Coverage Diff @@
## 1.x #5270 +/- ##
==========================================
+ Coverage 75.84% 75.93% +0.09%
==========================================
Files 872 872
Lines 68572 68871 +299
==========================================
+ Hits 52007 52296 +289
- Misses 16565 16575 +10
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
nizox
previously approved these changes
Mar 6, 2023
juanjux
previously approved these changes
Mar 6, 2023
juanjux
approved these changes
Mar 7, 2023
15 tasks
christophe-papazian
approved these changes
Mar 7, 2023
arbll
approved these changes
Mar 7, 2023
nizox
approved these changes
Mar 7, 2023
emmettbutler
approved these changes
Mar 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ASM
Application Security Monitoring
changelog/no-changelog
A changelog entry is not required for this PR.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remote Configuration should be able to store previous products target file content due to ASM needs to update all content/rules, the new once and the previous once.
further more, if a RC target file is disabled, RC should remove all configuration related to this target_file.
(Note: this bug was introduced with the new products in 1.10 so there is no need to backport).
e.g:
Actual behavior:
ASM_DD. New target fileASM_DD/file_12. Content:{"exclusions": [rule1]}{"exclusions": [rule1]}ASM_DD. New target fileASM_DD/file_34. Content:{"exclusions": [rule2]}{"exclusions": [rule2]}ASM_DD. Disable Target FileASM_DD/file_34. Content:{"exclusions": [rule2]}{"exclusions": []}With this PR the new behavior is:
ASM_DD. New target fileASM_DD/file_12. Content:{"exclusions": [rule1]}{"exclusions": [rule1]}ASM_DD. New target fileASM_DD/file_34. Content:{"exclusions": [rule2]}{"exclusions": [rule1, rule2]}ASM_DD. Disable Target FileASM_DD/file_34. Content:{"exclusions": [rule2]}{"exclusions": [rule1]}Affected versions
1.10.rcX
Checklist
Reviewer Checklist