Skip to content

Conversation

@brettlangdon
Copy link
Member

@brettlangdon brettlangdon commented Mar 30, 2023

Update the spelling list to include the words tracestate and whitespace which are needed for the build_docs job to complete successfully.

https://app.circleci.com/pipelines/github/DataDog/dd-trace-py/31885/workflows/36b716a8-d8dd-420f-b078-6b7a9eaa72c0/jobs/2157818

Checklist

  • Change(s) are motivated and described in the PR description.
  • Testing strategy is described if automated tests are not included in the PR.
  • Risk is outlined (performance impact, potential for breakage, maintainability, etc).
  • Change is maintainable (easy to change, telemetry, documentation).
  • Library release note guidelines are followed.
  • Documentation is included (in-code, generated user docs, public corp docs).
  • Author is aware of the performance implications of this PR as reported in the benchmarks PR comment.

Reviewer Checklist

  • Title is accurate.
  • No unnecessary changes are introduced.
  • Description motivates each change.
  • Avoids breaking API changes unless absolutely necessary.
  • Testing strategy adequately addresses listed risk(s).
  • Change is maintainable (easy to change, telemetry, documentation).
  • Release note makes sense to a user of the library.
  • Reviewer is aware of, and discussed the performance implications of this PR as reported in the benchmarks PR comment.

@brettlangdon brettlangdon added the changelog/no-changelog A changelog entry is not required for this PR. label Mar 30, 2023
@brettlangdon brettlangdon requested a review from a team as a code owner March 30, 2023 18:00
@brettlangdon
Copy link
Member Author

This PR targets 1.8 branch.

@emmettbutler emmettbutler enabled auto-merge (squash) March 30, 2023 19:15
@brettlangdon brettlangdon disabled auto-merge March 30, 2023 19:40
@brettlangdon
Copy link
Member Author

I need to override merge requirements because require-checklist job does not exist on the 1.8 branch.

@brettlangdon brettlangdon merged commit 0f36c3d into 1.8 Mar 30, 2023
@brettlangdon brettlangdon deleted the brettlangdon/1.8.spellinglist branch March 30, 2023 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/no-changelog A changelog entry is not required for this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants