Skip to content

ci(boto): add wait timeout when testing receiving request #5518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 11, 2023
Merged

ci(boto): add wait timeout when testing receiving request #5518

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a767380
Add wait timeout to receive request
Yun-Kim Apr 11, 2023
e390f8c
Merge branch '1.x' into yunkim/fix-flaky-boto
Yun-Kim Apr 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion tests/contrib/botocore/test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1605,7 +1605,11 @@ def test_sns_send_message_batch_trace_injection_with_max_message_attributes(self
spans = self.get_spans()

# get SNS messages via SQS
response = sqs.receive_message(QueueUrl=queue["QueueUrl"], MessageAttributeNames=["_datadog"])
response = sqs.receive_message(
QueueUrl=queue["QueueUrl"],
MessageAttributeNames=["_datadog"],
WaitTimeSeconds=10,
)

# clean up resources
sqs.delete_queue(QueueUrl=sqs_url)
Expand All @@ -1626,6 +1630,7 @@ def test_sns_send_message_batch_trace_injection_with_max_message_attributes(self
assert trace_json is None

# receive message using SQS and ensure headers are present
assert response.get("Messages"), response
assert len(response["Messages"]) == 1
msg = response["Messages"][0]
assert msg is not None
Expand Down