Skip to content

Conversation

@gnufede
Copy link
Member

@gnufede gnufede commented Jun 1, 2023

CI Visibility: If there is an exception while using the temporary dir to unpack git commits, use cwd instead.

This is an issue that happens on certain CI environments, not just for Python.

Checklist

  • Change(s) are motivated and described in the PR description.
  • Testing strategy is described if automated tests are not included in the PR.
  • Risk is outlined (performance impact, potential for breakage, maintainability, etc).
  • Change is maintainable (easy to change, telemetry, documentation).
  • Library release note guidelines are followed.
  • Documentation is included (in-code, generated user docs, public corp docs).

Reviewer Checklist

  • Title is accurate.
  • No unnecessary changes are introduced.
  • Description motivates each change.
  • Avoids breaking API changes unless absolutely necessary.
  • Testing strategy adequately addresses listed risk(s).
  • Change is maintainable (easy to change, telemetry, documentation).
  • Release note makes sense to a user of the library.
  • Reviewer has explicitly acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment.

@gnufede gnufede marked this pull request as ready for review June 2, 2023 07:05
@gnufede gnufede requested a review from a team as a code owner June 2, 2023 07:05
@gnufede gnufede requested review from ZStriker19 and majorgreys June 2, 2023 07:05
@gnufede gnufede added changelog/no-changelog A changelog entry is not required for this PR. CI App labels Jun 2, 2023
@pr-commenter
Copy link

pr-commenter bot commented Jun 2, 2023

Benchmarks

Comparing candidate commit 21df7d7 in PR branch gnufede/fix-git-temp-dir with baseline commit 08e3965 in branch 1.x.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 90 cases.

Copy link
Contributor

@majorgreys majorgreys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a manual test for this change?

@gnufede gnufede requested a review from majorgreys June 5, 2023 09:53
@gnufede gnufede enabled auto-merge (squash) June 6, 2023 14:36
@gnufede gnufede merged commit 3982879 into 1.x Jun 6, 2023
@gnufede gnufede deleted the gnufede/fix-git-temp-dir branch June 6, 2023 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/no-changelog A changelog entry is not required for this PR. CI App

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants