Skip to content

Conversation

@github-actions
Copy link
Contributor

Backport 021a9b2 from #6165 to 1.15.

Last version of setuptools seems to break github action framework tests.
Fix it by upgrading the version of asyncpg.

Checklist

  • Change(s) are motivated and described in the PR description.
  • Testing strategy is described if automated tests are not included in the PR.
  • Risk is outlined (performance impact, potential for breakage, maintainability, etc).
  • Change is maintainable (easy to change, telemetry, documentation).
  • Library release note guidelines are followed. If no release note is required, add label changelog/no-changelog.
  • Documentation is included (in-code, generated user docs, public corp docs).
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Title is accurate.
  • No unnecessary changes are introduced.
  • Description motivates each change.
  • Avoids breaking API changes unless absolutely necessary.
  • Testing strategy adequately addresses listed risk(s).
  • Change is maintainable (easy to change, telemetry, documentation).
  • Release note makes sense to a user of the library.
  • Reviewer has explicitly acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment.
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

Last version of setuptools seems to break github action framework tests.
Fix it by upgrading the version of asyncpg.

## Checklist

- [x] Change(s) are motivated and described in the PR description.
- [x] Testing strategy is described if automated tests are not included
in the PR.
- [x] Risk is outlined (performance impact, potential for breakage,
maintainability, etc).
- [x] Change is maintainable (easy to change, telemetry, documentation).
- [x] [Library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
are followed. If no release note is required, add label
`changelog/no-changelog`.
- [x] Documentation is included (in-code, generated user docs, [public
corp docs](https://github.com/DataDog/documentation/)).
- [x] Backport labels are set (if
[applicable](../docs/contributing.rst#release-branch-maintenance))

## Reviewer Checklist

- [x] Title is accurate.
- [x] No unnecessary changes are introduced.
- [x] Description motivates each change.
- [x] Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes unless absolutely necessary.
- [x] Testing strategy adequately addresses listed risk(s).
- [x] Change is maintainable (easy to change, telemetry, documentation).
- [x] Release note makes sense to a user of the library.
- [x] Reviewer has explicitly acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment.
- [x] Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](../docs/contributing.rst#release-branch-maintenance)

(cherry picked from commit 021a9b2)
@github-actions github-actions bot requested a review from a team as a code owner June 20, 2023 14:37
@github-actions github-actions bot requested a review from emmettbutler June 20, 2023 14:37
@github-actions github-actions bot added the changelog/no-changelog A changelog entry is not required for this PR. label Jun 20, 2023
@github-actions github-actions bot requested a review from ZStriker19 June 20, 2023 14:37
@pr-commenter
Copy link

pr-commenter bot commented Jun 20, 2023

Benchmarks

Comparing candidate commit 95c5209 in PR branch backport-6165-to-1.15 with baseline commit 1080f32 in branch 1.15.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 90 cases.

@brettlangdon brettlangdon merged commit f2b9050 into 1.15 Jun 20, 2023
@brettlangdon brettlangdon deleted the backport-6165-to-1.15 branch June 20, 2023 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/no-changelog A changelog entry is not required for this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants