Skip to content

Conversation

@avara1986
Copy link
Member

@avara1986 avara1986 commented Jun 28, 2023

Implement executed.source metric

Checklist

  • Change(s) are motivated and described in the PR description.
  • Testing strategy is described if automated tests are not included in the PR.
  • Risk is outlined (performance impact, potential for breakage, maintainability, etc).
  • Change is maintainable (easy to change, telemetry, documentation).
  • Library release note guidelines are followed. If no release note is required, add label changelog/no-changelog.
  • Documentation is included (in-code, generated user docs, public corp docs).
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Title is accurate.
  • No unnecessary changes are introduced.
  • Description motivates each change.
  • Avoids breaking API changes unless absolutely necessary.
  • Testing strategy adequately addresses listed risk(s).
  • Change is maintainable (easy to change, telemetry, documentation).
  • Release note makes sense to a user of the library.
  • Reviewer has explicitly acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment.
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@avara1986 avara1986 added changelog/no-changelog A changelog entry is not required for this PR. ASM Application Security Monitoring labels Jun 28, 2023
@pr-commenter
Copy link

pr-commenter bot commented Jun 28, 2023

Benchmarks

Comparing candidate commit dc82cd6 in PR branch avara1986/APPSEC-10269-iast_metrics with baseline commit a346cdd in branch 1.x.

Found 2 performance improvements and 0 performance regressions! Performance is the same for 92 cases.

scenario:flasksimple-appsec-get

  • 🟩 execution_time [-0.328ms; -0.289ms] or [-5.194%; -4.583%]

scenario:flasksimple-appsec-telemetry

  • 🟩 execution_time [-0.340ms; -0.299ms] or [-5.363%; -4.709%]

@avara1986 avara1986 marked this pull request as ready for review June 29, 2023 09:20
@avara1986 avara1986 requested review from a team as code owners June 29, 2023 09:20
@juanjux juanjux merged commit 9aa89e6 into 1.x Jun 30, 2023
@juanjux juanjux deleted the avara1986/APPSEC-10269-iast_metrics branch June 30, 2023 08:03
@github-actions github-actions bot added this to the v1.16.0 milestone Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ASM Application Security Monitoring changelog/no-changelog A changelog entry is not required for this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants