Skip to content

Conversation

@P403n1x87
Copy link
Contributor

Backport of #6255 to 1.14

The re module imports from the sre_constants module at runtime. This might cause issues when modules are unloaded in the sitecustomize.

Fixes #6197.

Checklist

  • Change(s) are motivated and described in the PR description.
  • Testing strategy is described if automated tests are not included in the PR.
  • Risk is outlined (performance impact, potential for breakage, maintainability, etc).
  • Change is maintainable (easy to change, telemetry, documentation).
  • Library release note guidelines are followed. If no release note is required, add label changelog/no-changelog.
  • Documentation is included (in-code, generated user docs, public corp docs).
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Title is accurate.
  • No unnecessary changes are introduced.
  • Description motivates each change.
  • Avoids breaking API changes unless absolutely necessary.
  • Testing strategy adequately addresses listed risk(s).
  • Change is maintainable (easy to change, telemetry, documentation).
  • Release note makes sense to a user of the library.
  • Reviewer has explicitly acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment.
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

The re module imports from the sre_constants module at runtime. This
might cause issues when modules are unloaded in the sitecustomize.

Fixes #6197.

(cherry picked from commit cda3001)
@P403n1x87 P403n1x87 requested review from a team as code owners July 11, 2023 15:00
@P403n1x87 P403n1x87 requested review from Yun-Kim and mabdinur July 11, 2023 15:00
@P403n1x87 P403n1x87 self-assigned this Jul 11, 2023
@P403n1x87 P403n1x87 enabled auto-merge (squash) July 11, 2023 15:00
@pr-commenter
Copy link

pr-commenter bot commented Jul 11, 2023

Benchmarks

Comparing candidate commit e631ad7 in PR branch backport-6255-to-1.14 with baseline commit 84d8893 in branch 1.14.

Found 0 performance improvements and 1 performance regressions! Performance is the same for 93 cases.

scenario:flasksimple-tracer-and-profiler

  • 🟥 execution_time [+0.371ms; +0.486ms] or [+6.040%; +7.914%]

@P403n1x87 P403n1x87 merged commit c789aaa into 1.14 Jul 12, 2023
@P403n1x87 P403n1x87 deleted the backport-6255-to-1.14 branch July 12, 2023 10:04
@github-actions github-actions bot added this to the v1.14.4 milestone Jul 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants