ci(opentelemetry): pin cattrs and otel-flask-instrumentation [backport 1.20] #7688
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
changelog/no-changelog
github-actions
bot
requested review from
Kyle-Verhoog,
ZStriker19 and
emmettbutler
mabdinur
force-pushed
the
backport-7682-to-1.20
branch
from
c6b0282 to
a275315
Compare
ZStriker19
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are three commits needed to fix tracer and opentelemetry tests on 1.20. This PR cherry picks these changes and fixes many painful merge conflicts:
Commit 1: Tried to fix tracer+opentelemetry in one PR (this failed).
Commit 2: Reverted the broken otel cattrs fix (but not the tracer fix)
Commit 3: Finally fix the otel tests by pinning cattrs and otel-flask-instrumentation