Skip to content

Conversation

@brettlangdon
Copy link
Member

This PR adds a CircleCI step to test running python setup.py sdist and twine check on our package.

This job is fast and should pass about 99.9% of the time, but acts as a quick/easy way for us to know if either our deploy script could fail to build the package distribution or if there is an issue with rendering our setup.py long_description.

Copy link
Contributor

@majorgreys majorgreys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brettlangdon brettlangdon merged commit 5db43d2 into 0.19-dev Dec 26, 2018
@brettlangdon brettlangdon added this to the 0.19.0 milestone Dec 27, 2018
@brettlangdon brettlangdon mentioned this pull request Dec 28, 2018
@brettlangdon brettlangdon deleted the brettlangdon/test.build branch July 21, 2019 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants