Skip to content

Conversation

@Yun-Kim
Copy link
Contributor

@Yun-Kim Yun-Kim commented Jun 5, 2024

This PR removes an import from the ddtrace.contrib.anthropic.* directory made by the ddtrace.llmobs.integrations module, as this can lead to circular imports (ex: langchain conftest imports langchain unpatch, langchain unpatch imports LangchainIntegration, LangchainIntegration imports from base, base imports from Anthropic integration, Anthropic integration imports from anthropic contrib, anthropic contrib imports Anthropic integration --> circular error)

There is no change in functionality - existing tests verify this.

Checklist

  • Change(s) are motivated and described in the PR description
  • Testing strategy is described if automated tests are not included in the PR
  • Risks are described (performance impact, potential for breakage, maintainability)
  • Change is maintainable (easy to change, telemetry, documentation)
  • Library release note guidelines are followed or label changelog/no-changelog is set
  • Documentation is included (in-code, generated user docs, public corp docs)
  • Backport labels are set (if applicable)
  • If this PR changes the public interface, I've notified @DataDog/apm-tees.

Reviewer Checklist

  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Description motivates each change
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Change is maintainable (easy to change, telemetry, documentation)
  • Release note makes sense to a user of the library
  • Author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

@Yun-Kim Yun-Kim added the changelog/no-changelog A changelog entry is not required for this PR. label Jun 5, 2024
@Yun-Kim Yun-Kim requested a review from a team as a code owner June 5, 2024 16:44
@Yun-Kim Yun-Kim enabled auto-merge (squash) June 5, 2024 16:46
@Yun-Kim
Copy link
Contributor Author

Yun-Kim commented Jun 5, 2024

Closing as this will be fixed in #9462

@Yun-Kim Yun-Kim closed this Jun 5, 2024
auto-merge was automatically disabled June 5, 2024 18:52

Pull request was closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/no-changelog A changelog entry is not required for this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants