Set Rack event_sample_rate default #668
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delner
added
core
palazzem
suggested changes
Jan 22, 2019
There was a problem hiding this comment.
We're changing the default behavior. The latest is to provide an easy way to enable it via config and not to enable it by default. For now let's put this PR on-hold, probably the only required change is setting the event_sample_rate option to 0.0, while users can enable it simply by declaring.
delner
force-pushed
the
feature/set_rack_event_sample_rate_default
branch
from
0aa2677 to
2de2f34
Compare
|
@delner closing this PR, we do not need to implement this change anymore. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request sets
event_sample_ratetag value to1.0by default for Rack.