Skip to content

Conversation

r1viollet
Copy link
Collaborator

@r1viollet r1viollet commented Jun 28, 2023

What does this PR do?

Add an environment variable to the internal stat field
Adjust the format if it contains unix://
Revert removal of env var for pprof_prefix

Motivation

Make it easier to set the internal stats field.
Avoid breaking relenv
Fix prof-correctness tests

sanchda
sanchda previously approved these changes Jun 28, 2023
Copy link
Contributor

@sanchda sanchda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, this is a good idea. Thank you!

Re-generate the help documentation
@r1viollet r1viollet force-pushed the r1viollet/add_env_internal_stats branch from e3c911d to 4025171 Compare June 28, 2023 15:24
@r1viollet
Copy link
Collaborator Author

Yeah, this is a good idea. Thank you!

Thanks. CI was failing due to documentation updates. I think PR is now ready!

nsavoire
nsavoire previously approved these changes Jun 29, 2023
Remove UDS path adjustement function from header.
Copy link
Collaborator

@nsavoire nsavoire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@r1viollet r1viollet merged commit ad86a2f into main Jun 29, 2023
@r1viollet r1viollet deleted the r1viollet/add_env_internal_stats branch June 29, 2023 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants