Skip to content

Conversation

r1viollet
Copy link
Collaborator

@r1viollet r1viollet commented Mar 11, 2025

What does this PR do?

There is a bug in how the inlined functions are ordered in the stack traces

Motivation

Fixing a report from the user.

Additional Notes

The test was incomplete and did not catch the issue.

How to test the change?

DataDog/prof-correctness#48

There is a bug in how the inlined functions are ordered in the stack traces
@pr-commenter
Copy link

pr-commenter bot commented Mar 11, 2025

Benchmark results for collatz

Parameters

Baseline Candidate
config baseline candidate
profiler-version ddprof 0.19.0+92480eba.53556101 ddprof 0.19.0+07c7ad1c.58377769

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics.

See unchanged results
scenario Δ mean execution_time
scenario:ddprof -S bench-collatz --preset cpu_only collatz_runner.sh same

@pr-commenter
Copy link

pr-commenter bot commented Mar 11, 2025

Benchmark results for BadBoggleSolver_run

Parameters

Baseline Candidate
config baseline candidate
profiler-version ddprof 0.19.0+92480eba.53556101 ddprof 0.19.0+07c7ad1c.58377769

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics.

See unchanged results
scenario Δ mean execution_time
scenario:ddprof -S bench-bad-boggle-solver BadBoggleSolver_run work 1000 same

@r1viollet r1viollet marked this pull request as ready for review March 11, 2025 08:50
@r1viollet r1viollet changed the title Reverse inlining order Reverse order of inlined functions in stacks Mar 11, 2025
@r1viollet r1viollet merged commit b2a562b into main Mar 12, 2025
1 check passed
@r1viollet r1viollet deleted the r1viollet/reverse_inlined_func_order branch March 12, 2025 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants