use 'nf_conntrack' instead of 'nf_conntrack_ipv4' for linux kernel >= 4.19 #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EricMountain
commented
May 29, 2020
EricMountain
force-pushed
the
eric.mountain/kube-proxy-ipvs-for-big-kernel
branch
from
c6b4280 to
24262f5
Compare
dbenque
reviewed
May 29, 2020
| wantModules := sets.NewString() | ||
| loadModules := sets.NewString() | ||
| linuxKernelHandler := NewLinuxKernelHandler() | ||
| _, ipvsModules, _ := utilipvs.GetKernelVersionAndIPVSMods(linuxKernelHandler.executor) |
There was a problem hiding this comment.
Interestingly upstream chose to explicitly ignore errors.
Basically we're only interested in the 2nd return value, and in error paths it is nil, so ipvsModules will be nil. This leads to wantModules being empty, and then potentially the len(modules) bit fails lower down. So there's something handling it it seems. Haven't looked at the details of mods, err := handle.GetModules(), however I not particularly tempted to deviate from upstream just for this.
dbenque
approved these changes
May 29, 2020
| wantModules := sets.NewString() | ||
| loadModules := sets.NewString() | ||
| linuxKernelHandler := NewLinuxKernelHandler() | ||
| _, ipvsModules, _ := utilipvs.GetKernelVersionAndIPVSMods(linuxKernelHandler.executor) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of kubernetes#70398