Skip to content

[crashtracking] fix SA_ONSTACK #713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 6, 2024
Merged

[crashtracking] fix SA_ONSTACK #713

merged 5 commits into from
Nov 6, 2024

Conversation

@sanchda
Copy link
Contributor

@sanchda sanchda commented Nov 6, 2024

What does this PR do?

In my last crashtracking PR, I split up the configuration for using and enabling the altstack. However, since this was really tricky to test, it wasn't tested, so of course there was a typo (use is unused and create implies both)

Motivation

Fixing crashtracking

Additional Notes

Anything else we should know when reviewing?

How to test the change?

Tests are implemented now for all variants

  • use, but do not create
  • create and use
  • do not use, but create (paradox!)
  • do not use, do not create

@sanchda sanchda requested a review from a team as a code owner November 6, 2024 13:55
@pr-commenter
Copy link

pr-commenter bot commented Nov 6, 2024 •
edited
Loading

Benchmarks

Comparison

Benchmark execution time: 2024-11-06 15:17:39

Comparing candidate commit 09f4c52 in PR branch sanchda/fix_saonstack with baseline commit 7039e0f in branch main.

Found 0 performance improvements and 2 performance regressions! Performance is the same for 49 metrics, 2 unstable metrics.

scenario:redis/obfuscate_redis_string

  • 🟥 execution_time [+1.030µs; +1.405µs] or [+2.855%; +3.896%]

scenario:tags/replace_trace_tags

  • 🟥 execution_time [+76.267ns; +81.698ns] or [+2.891%; +3.097%]

Candidate

Candidate benchmark details

Group 1

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 09f4c52 1730905602 sanchda/fix_saonstack
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time 507.430µs 508.127µs ± 0.321µs 508.079µs ± 0.188µs 508.329µs 508.742µs 508.937µs 509.162µs 0.21% 0.586 0.362 0.06% 0.023µs 1 200
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput 1964011.908op/s 1968012.577op/s ± 1244.246op/s 1968197.289op/s ± 728.772op/s 1968864.835op/s 1969786.419op/s 1970440.223op/s 1970716.543op/s 0.13% -0.582 0.356 0.06% 87.981op/s 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time 468.282µs 470.157µs ± 0.778µs 470.255µs ± 0.498µs 470.664µs 471.366µs 471.901µs 472.547µs 0.49% -0.136 -0.055 0.17% 0.055µs 1 200
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput 2116193.267op/s 2126952.991op/s ± 3519.785op/s 2126504.524op/s ± 2254.208op/s 2129223.051op/s 2133355.562op/s 2134972.213op/s 2135463.462op/s 0.42% 0.146 -0.060 0.17% 248.886op/s 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time 184.293µs 185.018µs ± 0.204µs 185.051µs ± 0.118µs 185.152µs 185.286µs 185.420µs 185.482µs 0.23% -0.829 1.018 0.11% 0.014µs 1 200
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput 5391359.457op/s 5404876.658op/s ± 5967.866op/s 5403902.171op/s ± 3435.261op/s 5407825.407op/s 5416325.523op/s 5423153.415op/s 5426144.275op/s 0.41% 0.837 1.035 0.11% 421.992op/s 1 200
normalization/normalize_service/normalize_service/[empty string] execution_time 45.703µs 46.340µs ± 0.256µs 46.405µs ± 0.181µs 46.561µs 46.660µs 46.716µs 46.738µs 0.72% -0.507 -0.984 0.55% 0.018µs 1 200
normalization/normalize_service/normalize_service/[empty string] throughput 21395929.900op/s 21580116.428op/s ± 119615.942op/s 21549408.454op/s ± 83916.048op/s 21681076.952op/s 21795295.437op/s 21811853.034op/s 21880634.453op/s 1.54% 0.519 -0.969 0.55% 8458.124op/s 1 200
normalization/normalize_service/normalize_service/test_ASCII execution_time 49.470µs 50.466µs ± 0.383µs 50.469µs ± 0.274µs 50.730µs 51.084µs 51.218µs 51.254µs 1.56% -0.132 -0.546 0.76% 0.027µs 1 200
normalization/normalize_service/normalize_service/test_ASCII throughput 19510600.683op/s 19816291.510op/s ± 150382.024op/s 19814087.928op/s ± 107516.857op/s 19924394.244op/s 20080466.986op/s 20154178.100op/s 20214381.843op/s 2.02% 0.164 -0.526 0.76% 10633.615op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... execution_time [508.082µs; 508.172µs] or [-0.009%; +0.009%] None None None
normalization/normalize_service/normalize_service/A0000000000000000000000000000000000000000000000000... throughput [1967840.136op/s; 1968185.017op/s] or [-0.009%; +0.009%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて execution_time [470.050µs; 470.265µs] or [-0.023%; +0.023%] None None None
normalization/normalize_service/normalize_service/Data🐨dog🐶 繋がっ⛰てて throughput [2126465.183op/s; 2127440.800op/s] or [-0.023%; +0.023%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters execution_time [184.990µs; 185.047µs] or [-0.015%; +0.015%] None None None
normalization/normalize_service/normalize_service/Test Conversion 0f Weird !@#$%^&**() Characters throughput [5404049.570op/s; 5405703.747op/s] or [-0.015%; +0.015%] None None None
normalization/normalize_service/normalize_service/[empty string] execution_time [46.305µs; 46.376µs] or [-0.077%; +0.077%] None None None
normalization/normalize_service/normalize_service/[empty string] throughput [21563538.809op/s; 21596694.047op/s] or [-0.077%; +0.077%] None None None
normalization/normalize_service/normalize_service/test_ASCII execution_time [50.413µs; 50.519µs] or [-0.105%; +0.105%] None None None
normalization/normalize_service/normalize_service/test_ASCII throughput [19795450.008op/s; 19837133.012op/s] or [-0.105%; +0.105%] None None None

Group 2

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 09f4c52 1730905602 sanchda/fix_saonstack
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time 251.730µs 252.038µs ± 0.154µs 252.024µs ± 0.082µs 252.109µs 252.295µs 252.396µs 253.090µs 0.42% 1.890 9.893 0.06% 0.011µs 1 200
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput 3951157.574op/s 3967659.088op/s ± 2419.768op/s 3967876.837op/s ± 1291.267op/s 3969103.347op/s 3970675.689op/s 3971653.496op/s 3972504.121op/s 0.12% -1.875 9.768 0.06% 171.103op/s 1 200
normalization/normalize_name/normalize_name/bad-name execution_time 24.649µs 24.770µs ± 0.062µs 24.768µs ± 0.044µs 24.810µs 24.875µs 24.917µs 24.971µs 0.82% 0.277 -0.131 0.25% 0.004µs 1 200
normalization/normalize_name/normalize_name/bad-name throughput 40046052.961op/s 40371961.906op/s ± 100420.644op/s 40374533.623op/s ± 72033.934op/s 40447306.030op/s 40524747.485op/s 40562130.283op/s 40570039.101op/s 0.48% -0.264 -0.150 0.25% 7100.812op/s 1 200
normalization/normalize_name/normalize_name/good execution_time 15.709µs 15.739µs ± 0.024µs 15.724µs ± 0.009µs 15.759µs 15.784µs 15.803µs 15.810µs 0.54% 0.783 -0.236 0.15% 0.002µs 1 200
normalization/normalize_name/normalize_name/good throughput 63253040.626op/s 63536203.348op/s ± 95271.816op/s 63597285.034op/s ± 37400.960op/s 63613408.601op/s 63634685.995op/s 63644950.479op/s 63659160.368op/s 0.10% -0.778 -0.252 0.15% 6736.735op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... execution_time [252.017µs; 252.059µs] or [-0.008%; +0.008%] None None None
normalization/normalize_name/normalize_name/Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Long-.Too-Lo... throughput [3967323.732op/s; 3967994.445op/s] or [-0.008%; +0.008%] None None None
normalization/normalize_name/normalize_name/bad-name execution_time [24.761µs; 24.778µs] or [-0.034%; +0.034%] None None None
normalization/normalize_name/normalize_name/bad-name throughput [40358044.570op/s; 40385879.241op/s] or [-0.034%; +0.034%] None None None
normalization/normalize_name/normalize_name/good execution_time [15.736µs; 15.742µs] or [-0.021%; +0.021%] None None None
normalization/normalize_name/normalize_name/good throughput [63522999.591op/s; 63549407.106op/s] or [-0.021%; +0.021%] None None None

Group 3

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 09f4c52 1730905602 sanchda/fix_saonstack
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
redis/obfuscate_redis_string execution_time 36.713µs 37.279µs ± 1.014µs 36.802µs ± 0.054µs 36.943µs 39.464µs 39.537µs 40.099µs 8.96% 1.699 0.946 2.71% 0.072µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
redis/obfuscate_redis_string execution_time [37.138µs; 37.419µs] or [-0.377%; +0.377%] None None None

Group 4

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 09f4c52 1730905602 sanchda/fix_saonstack
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
tags/replace_trace_tags execution_time 2.689µs 2.717µs ± 0.010µs 2.718µs ± 0.006µs 2.724µs 2.732µs 2.738µs 2.741µs 0.85% -0.327 0.077 0.36% 0.001µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
tags/replace_trace_tags execution_time [2.716µs; 2.718µs] or [-0.050%; +0.050%] None None None

Group 5

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 09f4c52 1730905602 sanchda/fix_saonstack
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching string interning on wordpress profile execution_time 141.585µs 142.828µs ± 0.352µs 142.816µs ± 0.164µs 143.001µs 143.386µs 143.840µs 144.031µs 0.85% 0.137 2.114 0.25% 0.025µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching string interning on wordpress profile execution_time [142.779µs; 142.876µs] or [-0.034%; +0.034%] None None None

Group 6

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 09f4c52 1730905602 sanchda/fix_saonstack
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
normalization/normalize_trace/test_trace execution_time 288.914ns 301.764ns ± 15.046ns 293.079ns ± 3.161ns 312.858ns 333.888ns 337.779ns 337.913ns 15.30% 1.051 -0.380 4.97% 1.064ns 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
normalization/normalize_trace/test_trace execution_time [299.679ns; 303.849ns] or [-0.691%; +0.691%] None None None

Group 7

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 09f4c52 1730905602 sanchda/fix_saonstack
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
write only interface execution_time 1.359µs 3.278µs ± 1.427µs 3.127µs ± 0.024µs 3.150µs 3.183µs 14.057µs 15.096µs 382.71% 7.558 57.371 43.42% 0.101µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
write only interface execution_time [3.080µs; 3.476µs] or [-6.033%; +6.033%] None None None

Group 8

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 09f4c52 1730905602 sanchda/fix_saonstack
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
concentrator/add_spans_to_concentrator execution_time 9.074ms 9.117ms ± 0.031ms 9.116ms ± 0.013ms 9.128ms 9.144ms 9.159ms 9.465ms 3.83% 7.033 76.792 0.34% 0.002ms 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
concentrator/add_spans_to_concentrator execution_time [9.113ms; 9.121ms] or [-0.047%; +0.047%] None None None

Group 9

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 09f4c52 1730905602 sanchda/fix_saonstack
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
benching deserializing traces from msgpack to their internal representation execution_time 1.137µs 1.203µs ± 0.024µs 1.210µs ± 0.012µs 1.222µs 1.226µs 1.227µs 1.228µs 1.53% -1.428 1.179 1.97% 0.002µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
benching deserializing traces from msgpack to their internal representation execution_time [1.200µs; 1.207µs] or [-0.274%; +0.274%] None None None

Group 10

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 09f4c52 1730905602 sanchda/fix_saonstack
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
two way interface execution_time 18.954µs 25.297µs ± 10.907µs 19.827µs ± 0.256µs 27.410µs 45.073µs 47.908µs 104.511µs 427.11% 3.005 14.578 43.01% 0.771µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
two way interface execution_time [23.785µs; 26.808µs] or [-5.976%; +5.976%] None None None

Group 11

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 09f4c52 1730905602 sanchda/fix_saonstack
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
credit_card/is_card_number/ execution_time 4.606µs 4.620µs ± 0.003µs 4.620µs ± 0.002µs 4.622µs 4.625µs 4.627µs 4.636µs 0.35% 0.308 2.704 0.07% 0.000µs 1 200
credit_card/is_card_number/ throughput 215721044.604op/s 216470388.985op/s ± 156564.288op/s 216470561.434op/s ± 98250.375op/s 216571271.821op/s 216684829.964op/s 216773437.625op/s 217095933.952op/s 0.29% -0.298 2.686 0.07% 11070.767op/s 1 200
credit_card/is_card_number/ 3782-8224-6310-005 execution_time 89.852µs 91.382µs ± 0.780µs 91.239µs ± 0.449µs 91.882µs 92.735µs 93.156µs 94.629µs 3.72% 0.705 0.843 0.85% 0.055µs 1 200
credit_card/is_card_number/ 3782-8224-6310-005 throughput 10567550.473op/s 10943859.882op/s ± 92901.328op/s 10960194.793op/s ± 53923.011op/s 10998585.857op/s 11076200.215op/s 11116788.110op/s 11129424.073op/s 1.54% -0.646 0.682 0.85% 6569.116op/s 1 200
credit_card/is_card_number/ 378282246310005 execution_time 84.707µs 86.141µs ± 0.447µs 86.168µs ± 0.177µs 86.273µs 86.673µs 86.923µs 89.989µs 4.43% 2.986 26.240 0.52% 0.032µs 1 200
credit_card/is_card_number/ 378282246310005 throughput 11112473.524op/s 11609241.593op/s ± 59384.509op/s 11605278.874op/s ± 23883.404op/s 11639099.468op/s 11693270.815op/s 11718660.644op/s 11805397.408op/s 1.72% -2.698 23.378 0.51% 4199.119op/s 1 200
credit_card/is_card_number/37828224631 execution_time 4.607µs 4.619µs ± 0.003µs 4.619µs ± 0.002µs 4.621µs 4.624µs 4.626µs 4.628µs 0.20% 0.135 0.907 0.06% 0.000µs 1 200
credit_card/is_card_number/37828224631 throughput 216076403.818op/s 216506248.218op/s ± 140542.188op/s 216510089.370op/s ± 93561.225op/s 216608515.452op/s 216713912.935op/s 216774304.693op/s 217052420.114op/s 0.25% -0.129 0.911 0.06% 9937.833op/s 1 200
credit_card/is_card_number/378282246310005 execution_time 81.754µs 83.356µs ± 0.452µs 83.391µs ± 0.299µs 83.680µs 84.012µs 84.293µs 84.880µs 1.79% -0.269 0.873 0.54% 0.032µs 1 200
credit_card/is_card_number/378282246310005 throughput 11781365.891op/s 11997079.454op/s ± 65125.634op/s 11991769.484op/s ± 42801.452op/s 12039239.953op/s 12116908.057op/s 12147857.060op/s 12231775.362op/s 2.00% 0.314 0.884 0.54% 4605.078op/s 1 200
credit_card/is_card_number/37828224631000521389798 execution_time 58.062µs 58.630µs ± 0.288µs 58.690µs ± 0.200µs 58.874µs 58.935µs 58.990µs 59.120µs 0.73% -0.613 -0.944 0.49% 0.020µs 1 200
credit_card/is_card_number/37828224631000521389798 throughput 16914639.234op/s 17056446.892op/s ± 84138.720op/s 17038684.619op/s ± 57913.397op/s 17116849.953op/s 17215167.231op/s 17220616.246op/s 17222932.123op/s 1.08% 0.623 -0.931 0.49% 5949.506op/s 1 200
credit_card/is_card_number/x371413321323331 execution_time 6.538µs 6.545µs ± 0.005µs 6.545µs ± 0.002µs 6.546µs 6.550µs 6.552µs 6.608µs 0.96% 9.205 109.833 0.08% 0.000µs 1 200
credit_card/is_card_number/x371413321323331 throughput 151329366.087op/s 152778166.525op/s ± 118830.928op/s 152784752.082op/s ± 43336.052op/s 152834552.072op/s 152866203.295op/s 152882025.334op/s 152958388.411op/s 0.11% -9.142 108.797 0.08% 8402.616op/s 1 200
credit_card/is_card_number_no_luhn/ execution_time 4.602µs 4.618µs ± 0.003µs 4.618µs ± 0.002µs 4.619µs 4.622µs 4.623µs 4.624µs 0.15% -0.993 4.880 0.06% 0.000µs 1 200
credit_card/is_card_number_no_luhn/ throughput 216247667.675op/s 216561434.680op/s ± 131412.011op/s 216563260.043op/s ± 83080.610op/s 216644525.868op/s 216751887.819op/s 216801997.154op/s 217299269.048op/s 0.34% 1.004 4.938 0.06% 9292.232op/s 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time 67.289µs 68.395µs ± 0.520µs 68.390µs ± 0.334µs 68.729µs 69.297µs 69.797µs 70.161µs 2.59% 0.352 0.474 0.76% 0.037µs 1 200
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput 14253014.076op/s 14621761.360op/s ± 110857.486op/s 14621996.343op/s ± 71446.353op/s 14691861.157op/s 14800425.034op/s 14854665.973op/s 14861170.884op/s 1.64% -0.300 0.389 0.76% 7838.808op/s 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time 62.765µs 63.549µs ± 0.477µs 63.512µs ± 0.357µs 63.881µs 64.470µs 64.515µs 64.765µs 1.97% 0.351 -0.740 0.75% 0.034µs 1 200
credit_card/is_card_number_no_luhn/ 378282246310005 throughput 15440391.733op/s 15736833.547op/s ± 117746.128op/s 15745129.013op/s ± 88633.291op/s 15827310.581op/s 15907183.805op/s 15925204.652op/s 15932406.262op/s 1.19% -0.326 -0.766 0.75% 8325.909op/s 1 200
credit_card/is_card_number_no_luhn/37828224631 execution_time 4.602µs 4.618µs ± 0.003µs 4.618µs ± 0.002µs 4.620µs 4.624µs 4.627µs 4.632µs 0.30% 0.142 4.139 0.07% 0.000µs 1 200
credit_card/is_card_number_no_luhn/37828224631 throughput 215887571.016op/s 216526049.337op/s ± 153164.644op/s 216525385.352op/s ± 94359.538op/s 216633724.458op/s 216733517.600op/s 216775472.593op/s 217314857.223op/s 0.36% -0.129 4.165 0.07% 10830.376op/s 1 200
credit_card/is_card_number_no_luhn/378282246310005 execution_time 60.059µs 60.603µs ± 0.259µs 60.615µs ± 0.224µs 60.848µs 60.920µs 60.972µs 61.065µs 0.74% -0.381 -0.959 0.43% 0.018µs 1 200
credit_card/is_card_number_no_luhn/378282246310005 throughput 16376070.809op/s 16501053.120op/s ± 70673.303op/s 16497692.013op/s ± 60664.663op/s 16554928.032op/s 16627179.393op/s 16648644.761op/s 16650409.812op/s 0.93% 0.393 -0.947 0.43% 4997.357op/s 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time 58.066µs 58.643µs ± 0.269µs 58.710µs ± 0.178µs 58.877µs 58.906µs 59.096µs 59.112µs 0.68% -0.664 -0.681 0.46% 0.019µs 1 200
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput 16916955.162op/s 17052713.986op/s ± 78542.275op/s 17032765.663op/s ± 51603.233op/s 17112540.926op/s 17213136.449op/s 17221242.403op/s 17221735.280op/s 1.11% 0.676 -0.662 0.46% 5553.778op/s 1 200
credit_card/is_card_number_no_luhn/x371413321323331 execution_time 6.539µs 6.544µs ± 0.002µs 6.544µs ± 0.002µs 6.546µs 6.549µs 6.550µs 6.550µs 0.09% 0.500 -0.413 0.03% 0.000µs 1 200
credit_card/is_card_number_no_luhn/x371413321323331 throughput 152668691.665op/s 152803073.357op/s ± 52730.733op/s 152806658.059op/s ± 40896.746op/s 152847080.521op/s 152869494.128op/s 152882565.428op/s 152927083.386op/s 0.08% -0.499 -0.415 0.03% 3728.626op/s 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
credit_card/is_card_number/ execution_time [4.619µs; 4.620µs] or [-0.010%; +0.010%] None None None
credit_card/is_card_number/ throughput [216448690.681op/s; 216492087.290op/s] or [-0.010%; +0.010%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 execution_time [91.274µs; 91.490µs] or [-0.118%; +0.118%] None None None
credit_card/is_card_number/ 3782-8224-6310-005 throughput [10930984.651op/s; 10956735.112op/s] or [-0.118%; +0.118%] None None None
credit_card/is_card_number/ 378282246310005 execution_time [86.079µs; 86.203µs] or [-0.072%; +0.072%] None None None
credit_card/is_card_number/ 378282246310005 throughput [11601011.471op/s; 11617471.715op/s] or [-0.071%; +0.071%] None None None
credit_card/is_card_number/37828224631 execution_time [4.618µs; 4.619µs] or [-0.009%; +0.009%] None None None
credit_card/is_card_number/37828224631 throughput [216486770.422op/s; 216525726.013op/s] or [-0.009%; +0.009%] None None None
credit_card/is_card_number/378282246310005 execution_time [83.293µs; 83.419µs] or [-0.075%; +0.075%] None None None
credit_card/is_card_number/378282246310005 throughput [11988053.667op/s; 12006105.240op/s] or [-0.075%; +0.075%] None None None
credit_card/is_card_number/37828224631000521389798 execution_time [58.590µs; 58.670µs] or [-0.068%; +0.068%] None None None
credit_card/is_card_number/37828224631000521389798 throughput [17044786.075op/s; 17068107.709op/s] or [-0.068%; +0.068%] None None None
credit_card/is_card_number/x371413321323331 execution_time [6.545µs; 6.546µs] or [-0.011%; +0.011%] None None None
credit_card/is_card_number/x371413321323331 throughput [152761697.701op/s; 152794635.349op/s] or [-0.011%; +0.011%] None None None
credit_card/is_card_number_no_luhn/ execution_time [4.617µs; 4.618µs] or [-0.008%; +0.008%] None None None
credit_card/is_card_number_no_luhn/ throughput [216543222.239op/s; 216579647.121op/s] or [-0.008%; +0.008%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 execution_time [68.323µs; 68.467µs] or [-0.105%; +0.105%] None None None
credit_card/is_card_number_no_luhn/ 3782-8224-6310-005 throughput [14606397.579op/s; 14637125.142op/s] or [-0.105%; +0.105%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 execution_time [63.483µs; 63.615µs] or [-0.104%; +0.104%] None None None
credit_card/is_card_number_no_luhn/ 378282246310005 throughput [15720515.066op/s; 15753152.027op/s] or [-0.104%; +0.104%] None None None
credit_card/is_card_number_no_luhn/37828224631 execution_time [4.618µs; 4.619µs] or [-0.010%; +0.010%] None None None
credit_card/is_card_number_no_luhn/37828224631 throughput [216504822.190op/s; 216547276.484op/s] or [-0.010%; +0.010%] None None None
credit_card/is_card_number_no_luhn/378282246310005 execution_time [60.567µs; 60.639µs] or [-0.059%; +0.059%] None None None
credit_card/is_card_number_no_luhn/378282246310005 throughput [16491258.480op/s; 16510847.760op/s] or [-0.059%; +0.059%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 execution_time [58.606µs; 58.680µs] or [-0.064%; +0.064%] None None None
credit_card/is_card_number_no_luhn/37828224631000521389798 throughput [17041828.782op/s; 17063599.190op/s] or [-0.064%; +0.064%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 execution_time [6.544µs; 6.545µs] or [-0.005%; +0.005%] None None None
credit_card/is_card_number_no_luhn/x371413321323331 throughput [152795765.384op/s; 152810381.329op/s] or [-0.005%; +0.005%] None None None

Group 12

cpu_model git_commit_sha git_commit_date git_branch
Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz 09f4c52 1730905602 sanchda/fix_saonstack
scenario metric min mean ± sd median ± mad p75 p95 p99 max peak_to_median_ratio skewness kurtosis cv sem runs sample_size
sql/obfuscate_sql_string execution_time 74.305µs 74.635µs ± 0.160µs 74.613µs ± 0.093µs 74.722µs 74.828µs 74.959µs 76.016µs 1.88% 3.410 26.590 0.21% 0.011µs 1 200
scenario metric 95% CI mean Shapiro-Wilk pvalue Ljung-Box pvalue (lag=1) Dip test pvalue
sql/obfuscate_sql_string execution_time [74.613µs; 74.657µs] or [-0.030%; +0.030%] None None None

Baseline

Omitted due to size.

@codecov-commenter
Copy link

codecov-commenter commented Nov 6, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 88.09524% with 40 lines in your changes missing coverage. Please review.

Project coverage is 71.27%. Comparing base (7039e0f) to head (09f4c52).

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #713      +/-   ##
==========================================
+ Coverage   70.64%   71.27%   +0.62%     
==========================================
  Files         281      281              
  Lines       41980    42315     +335     
==========================================
+ Hits        29657    30160     +503     
+ Misses      12323    12155     -168
Components Coverage Δ
crashtracker 37.29% <88.09%> (+18.09%) ⬆️
crashtracker-ffi 9.20% <ø> (ø)
datadog-alloc 98.73% <ø> (ø)
data-pipeline 91.93% <ø> (ø)
data-pipeline-ffi 0.00% <ø> (ø)
ddcommon 83.46% <ø> (+0.70%) ⬆️
ddcommon-ffi 69.12% <ø> (ø)
ddtelemetry 59.10% <ø> (ø)
ddtelemetry-ffi 22.13% <ø> (ø)
dogstatsd 89.45% <ø> (ø)
dogstatsd-client 79.77% <ø> (ø)
ipc 82.75% <ø> (ø)
profiling 84.30% <ø> (ø)
profiling-ffi 77.46% <ø> (ø)
serverless 0.00% <ø> (ø)
sidecar 37.42% <ø> (ø)
sidecar-ffi 0.00% <ø> (ø)
spawn-worker 50.36% <ø> (ø)
tinybytes 94.77% <ø> (ø)
trace-mini-agent 72.45% <ø> (ø)
trace-normalization 98.25% <ø> (ø)
trace-obfuscation 95.77% <ø> (ø)
trace-protobuf 77.67% <ø> (ø)
trace-utils 93.55% <ø> (ø)

@sanchda sanchda enabled auto-merge (squash) November 6, 2024 14:39
danielsn
danielsn approved these changes Nov 6, 2024
View reviewed changes
@sanchda sanchda merged commit 7c08b25 into main Nov 6, 2024
32 checks passed
@sanchda sanchda deleted the sanchda/fix_saonstack branch November 6, 2024 17:03
danielsn pushed a commit that referenced this pull request Nov 6, 2024
@sanchda @danielsn
[crashtracking] fix SA_ONSTACK (#713)
0e0b07d 
Fixes `use_alt_stack` to actually do something and adds tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danielsn danielsn danielsn approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sanchda @codecov-commenter @danielsn